From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D23F2112386A for ; Thu, 6 Sep 2018 11:41:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2018 11:41:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,339,1531810800"; d="scan'208";a="89581317" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 06 Sep 2018 11:41:57 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Sep 2018 11:41:57 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.126]) by fmsmsx115.amr.corp.intel.com ([169.254.4.182]) with mapi id 14.03.0319.002; Thu, 6 Sep 2018 11:41:56 -0700 From: "Carsey, Jaben" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the time Thread-Index: AQHURg/fIzwwPeHgyUytwNs5dAVpm6Tjll1A Date: Thu, 6 Sep 2018 18:41:55 +0000 Message-ID: References: <5ef06f7bf6d4df68579049c0d233c16d7867086a.1536258666.git.jaben.carsey@intel.com> In-Reply-To: <5ef06f7bf6d4df68579049c0d233c16d7867086a.1536258666.git.jaben.carsey@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjY3NjhhZDAtMzMyYy00NmYxLWFlYjAtMTZjODhkNTJlYzUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicFhcLzl5VXVycTJRNUE1Y2d3MEZLZFNPS1VZa3hFV0RZUXZUQVJtcDhWZzREeStxdEZaUGdFVVBucFVDK0E1MDIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the time X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 18:41:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have found a related issue. Please ignore this patch. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jaben Carsey > Sent: Thursday, September 06, 2018 11:31 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH v1 1/1] BaseTools/GenFds: Verify binaries all the = time >=20 > Currently, Basetools only verifies Binary file list existance for default= ARCH, > but it should verify for a specified ARCH the same. > Also, dont save the list to a unused variable. >=20 > Cc: Yonghong Zhu > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jaben Carsey > --- > BaseTools/Source/Python/GenFds/AprioriSection.py | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/GenFds/AprioriSection.py > b/BaseTools/Source/Python/GenFds/AprioriSection.py > index 7196f7f2c753..70aa150799a7 100644 > --- a/BaseTools/Source/Python/GenFds/AprioriSection.py > +++ b/BaseTools/Source/Python/GenFds/AprioriSection.py > @@ -89,12 +89,10 @@ class AprioriSection (AprioriSectionClassObject): > Inf =3D > GenFdsGlobalVariable.WorkSpace.BuildObject[PathClass(InfFileName, > GenFdsGlobalVariable.WorkSpaceDir), TAB_COMMON, > GenFdsGlobalVariable.TargetName, GenFdsGlobalVariable.ToolChainTag] > Guid =3D Inf.Guid >=20 > - self.BinFileList =3D Inf.Module.Binaries > - if self.BinFileList =3D=3D []: > - EdkLogger.error("GenFds", RESOURCE_NOT_AVAILABLE= , > - "INF %s not found in build ARCH = %s!" \ > - % (InfFileName, GenFdsGlobalVari= able.ArchList)) > - > + if not Inf.Module.Binaries: > + EdkLoggerError("GenFds", RESOURCE_NOT_AVAILABLE, > + "INF %s not found in build ARCH %s!"= \ > + % (InfFileName, GenFdsGlobalVariable= .ArchList)) >=20 > GuidPart =3D Guid.split('-') > Buffer.write(pack('I', long(GuidPart[0], 16))) > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel