Re: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code

["Carsey, Jaben" <jaben.carsey@intel.com>]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Monday, September 24, 2018 11:23 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Zhu, Yonghong
> <yonghong.zhu@intel.com>
> Subject: RE: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in
> AutoGen code
> Importance: High
> 
> Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
> 
> Best Regards,
> Zhu Yonghong
> 
> 
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, September 25, 2018 9:36 AM
> To: edk2-devel@lists.01.org
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> Subject: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in
> AutoGen code
> 
> DscBuildData has been updated to define SkuIds instead of _GetSkuIds().
> The consumer code should refer to SkuIds.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index 5271b44..38f1260 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen):
>                          VpdRegionBase = FdRegion.Offset
>                          break
> 
> -        VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(),
> self.DscBuildDataObj._GetSkuIds())
> +        VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(),
> self.DscBuildDataObj.SkuIds)
>          VariableInfo.SetVpdRegionMaxSize(VpdRegionSize)
>          VariableInfo.SetVpdRegionOffset(VpdRegionBase)
>          Index = 0
> --
> 2.10.0.windows.1