From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7100421154107 for ; Tue, 25 Sep 2018 07:48:48 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 07:48:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="75796372" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 25 Sep 2018 07:48:26 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 07:48:26 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.16]) by FMSMSX157.amr.corp.intel.com ([169.254.14.71]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 07:48:25 -0700 From: "Carsey, Jaben" To: "Zhu, Yonghong" , "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code Thread-Index: AQHUVHAu3scE0se/2UClI4ulbvktM6UA/MwAgAAX6bA= Date: Tue, 25 Sep 2018 14:48:25 +0000 Message-ID: References: <1537839360-10024-1-git-send-email-liming.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmQ5NjlhZDItZmQ4My00YjA4LWIxNTktODhhMmUxNWU4MGM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1RtXC9GUXAzWkNvQlpaSktJTTBndDY2RUpNT0lzdUt3XC92QjMwWVJVVGVnTFF1ZjE5QWhhVlhWcDI1ZGs2U0pCIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 14:48:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zhu, Yonghong > Sent: Monday, September 24, 2018 11:23 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Zhu, Yonghong > > Subject: RE: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code > Importance: High >=20 > Reviewed-by: Yonghong Zhu >=20 > Best Regards, > Zhu Yonghong >=20 >=20 > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, September 25, 2018 9:36 AM > To: edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Carsey, Jaben > > Subject: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code >=20 > DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). > The consumer code should refer to SkuIds. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Yonghong Zhu > Cc: Jaben Carsey > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 5271b44..38f1260 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): > VpdRegionBase =3D FdRegion.Offset > break >=20 > - VariableInfo =3D VariableMgr(self.DscBuildDataObj._GetDefaultSto= res(), > self.DscBuildDataObj._GetSkuIds()) > + VariableInfo =3D VariableMgr(self.DscBuildDataObj._GetDefaultSto= res(), > self.DscBuildDataObj.SkuIds) > VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) > VariableInfo.SetVpdRegionOffset(VpdRegionBase) > Index =3D 0 > -- > 2.10.0.windows.1