From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 774E821959CB2 for ; Tue, 25 Sep 2018 07:50:43 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 07:50:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="93106405" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 25 Sep 2018 07:50:42 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 07:50:42 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.16]) by fmsmsx111.amr.corp.intel.com ([169.254.12.10]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 07:50:41 -0700 From: "Carsey, Jaben" To: "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" , "Ni, Ruiyu" Thread-Topic: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused Thread-Index: AQHUVLi89tUramLJM0ugZsRNLV+CmqUBFLEw Date: Tue, 25 Sep 2018 14:50:41 +0000 Message-ID: References: <3570196b-4027-284a-e332-3121621bdc7e@solarflare.com> In-Reply-To: <3570196b-4027-284a-e332-3121621bdc7e@solarflare.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmRmMDY1OGEtZjJjYi00NWZlLTgzYzktNjAyOTM3ZjIwNDQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid09cLzRkMWwwS0QwRlVzYTM1TmI5ZG1sQ09EeVB3bVpQM0ZTa2tOYWY0Um8wXC9iK1VYb1NBZUUzeWpjdTdrMGtOIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 14:50:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I would prefer we just delete this. =20 Ray,=20 What do you think? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Tomas Pilar (tpilar) > Sent: Tuesday, September 25, 2018 3:15 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as > unused > Importance: High >=20 > This fixes unused const variable gcc 7.3 compilation error. Array is not > simply removed as the list of invalid characters might be salient > in future and for easy documentation. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Tomas Pilar > --- > ShellPkg/Application/Shell/Shell.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Application/Shell/Shell.c > b/ShellPkg/Application/Shell/Shell.c > index 397cfd1994..38b002a144 100644 > --- a/ShellPkg/Application/Shell/Shell.c > +++ b/ShellPkg/Application/Shell/Shell.c > @@ -2751,7 +2751,7 @@ RunCommand( > } >=20 >=20 > -STATIC CONST UINT16 InvalidChars[] =3D {L'*', L'?', L'<', L'>', L'\\', L= '/', L'\"', > 0x0001, 0x0002}; > +STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) =3D {L'*', L'= ?', > L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002}; >=20 > /** > Function to process a NSH script file via SHELL_FILE_HANDLE. > -- > 2.17.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel