From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>,
"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c
Date: Wed, 26 Sep 2018 15:39:33 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA4150117@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <f560c4e0-d4b1-d892-da39-673f1aaf50b8@solarflare.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tomas Pilar (tpilar)
> Sent: Wednesday, September 26, 2018 3:16 AM
> To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> Subject: [edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in
> Shell.c
> Importance: High
>
> This fixes unused const variable compilation error with gcc 7.3.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> ---
> ShellPkg/Application/Shell/Shell.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 397cfd1994..3f3bcbb4b0 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -2750,9 +2750,6 @@ RunCommand(
> return (RunShellCommand(CmdLine, NULL));
> }
>
> -
> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
> 0x0001, 0x0002};
> -
> /**
> Function to process a NSH script file via SHELL_FILE_HANDLE.
>
> --
> 2.17.1
>
> The information contained in this message is confidential and is intended for
> the addressee(s) only. If you have received this message in error, please
> notify the sender immediately and delete the message. Unless you are an
> addressee (or authorized to receive for an addressee), you may not use,
> copy or disclose to anyone this message or any information contained in this
> message. The unauthorized use, disclosure, copying or alteration of this
> message is strictly prohibited.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-09-26 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 10:15 [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c Tomas Pilar (tpilar)
2018-09-26 15:39 ` Carsey, Jaben [this message]
2018-09-27 2:45 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA4150117@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox