From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@ml01.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F8F821B02822 for ; Wed, 26 Sep 2018 08:43:59 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 08:43:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208";a="76105198" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 26 Sep 2018 08:39:35 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Sep 2018 08:39:35 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.16]) by fmsmsx158.amr.corp.intel.com ([169.254.15.101]) with mapi id 14.03.0319.002; Wed, 26 Sep 2018 08:39:35 -0700 From: "Carsey, Jaben" To: "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c Thread-Index: AQHUVYHljCGdg+TFo0igUaPXotcPZaUCszUQ Date: Wed, 26 Sep 2018 15:39:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmEwZjFmYjgtNWEzYS00YjJkLWIwMWQtOWVjOTMzMGE5YjQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVGFNTDNNVFpJbFwvZ0dJYUY2UWRZWXpiamE1cWxUaW5WNm8ybmpBT1dmdGRlUUtcL0J2UzdnR0MzMU1IUDRXMG5jIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 15:43:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Tomas Pilar (tpilar) > Sent: Wednesday, September 26, 2018 3:16 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in > Shell.c > Importance: High >=20 > This fixes unused const variable compilation error with gcc 7.3. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Tomas Pilar > --- > ShellPkg/Application/Shell/Shell.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/ShellPkg/Application/Shell/Shell.c > b/ShellPkg/Application/Shell/Shell.c > index 397cfd1994..3f3bcbb4b0 100644 > --- a/ShellPkg/Application/Shell/Shell.c > +++ b/ShellPkg/Application/Shell/Shell.c > @@ -2750,9 +2750,6 @@ RunCommand( > return (RunShellCommand(CmdLine, NULL)); > } >=20 > - > -STATIC CONST UINT16 InvalidChars[] =3D {L'*', L'?', L'<', L'>', L'\\', L= '/', L'\"', > 0x0001, 0x0002}; > - > /** > Function to process a NSH script file via SHELL_FILE_HANDLE. >=20 > -- > 2.17.1 >=20 > The information contained in this message is confidential and is intended= for > the addressee(s) only. If you have received this message in error, please > notify the sender immediately and delete the message. Unless you are an > addressee (or authorized to receive for an addressee), you may not use, > copy or disclose to anyone this message or any information contained in t= his > message. The unauthorized use, disclosure, copying or alteration of this > message is strictly prohibited. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel