Re: [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter.

["Carsey, Jaben" <jaben.carsey@intel.com>]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Sunday, October 07, 2018 8:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ye, Ting <ting.ye@intel.com>;
> Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>
> Subject: [edk2] [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct
> comments to align with the input parameter.
> Importance: High
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
> 
> Cc: Carsey Jaben <jaben.carsey@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> index d4391b9f33..ccf7abde42 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> @@ -163,10 +163,11 @@ GetFileSize (
>    @param[in]   Mtftp4         MTFTP4 protocol interface
>    @param[in]   FilePath       Path of the file, Unicode encoded
>    @param[in]   AsciiFilePath  Path of the file, ASCII encoded
>    @param[in]   FileSize       Size of the file in number of bytes
>    @param[in]   BlockSize      Value of the TFTP blksize option
> +  @param[in]   WindowSize     Value of the TFTP window size option
>    @param[out]  Data           Address where to store the address of the buffer
>                                where the data of the file were downloaded in
>                                case of success.
> 
>    @retval  EFI_SUCCESS           The file was downloaded.
> @@ -904,10 +905,11 @@ Error :
>    @param[in]   Mtftp4         MTFTP4 protocol interface
>    @param[in]   FilePath       Path of the file, Unicode encoded
>    @param[in]   AsciiFilePath  Path of the file, ASCII encoded
>    @param[in]   FileSize       Size of the file in number of bytes
>    @param[in]   BlockSize      Value of the TFTP blksize option
> +  @param[in]   WindowSize     Value of the TFTP window size option
>    @param[out]  Data           Address where to store the address of the buffer
>                                where the data of the file were downloaded in
>                                case of success.
> 
>    @retval  EFI_SUCCESS           The file was downloaded.
> --
> 2.17.1.windows.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel