From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D001D21163714 for ; Mon, 8 Oct 2018 07:49:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 07:49:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,357,1534834800"; d="scan'208";a="263871535" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 08 Oct 2018 07:47:36 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Oct 2018 07:47:36 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.16]) by FMSMSX113.amr.corp.intel.com ([169.254.13.112]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 07:47:36 -0700 From: "Carsey, Jaben" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" , "Wu, Jiaxin" , "Bi, Dandan" Thread-Topic: [edk2] [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter. Thread-Index: AQHUXrOsqdHR1ayky0iIjMgQZock+aUVbkXg Date: Mon, 8 Oct 2018 14:47:34 +0000 Message-ID: References: <20181008030325.4188-1-Jiaxin.wu@intel.com> <20181008030325.4188-3-Jiaxin.wu@intel.com> In-Reply-To: <20181008030325.4188-3-Jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ZlOWEwZDYtYmNiMi00ZTJmLWI2MzQtZDQ1M2NjMTliZjNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM2VWZ2dQSTlGYVR6cWVEcnptdXMrTXhUNlN2Q01McjVmXC9sQVVZZmNcL04wSmlOVlFcL0pQR2ljaEdcL0s0eXhhbHUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 14:49:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Sunday, October 07, 2018 8:03 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ye, Ting ; > Fu, Siyuan ; Wu, Jiaxin ; Bi, > Dandan > Subject: [edk2] [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct > comments to align with the input parameter. > Importance: High >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1230 >=20 > Cc: Carsey Jaben > Cc: Fu Siyuan > Cc: Ye Ting > Cc: Bi Dandan > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > index d4391b9f33..ccf7abde42 100644 > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > @@ -163,10 +163,11 @@ GetFileSize ( > @param[in] Mtftp4 MTFTP4 protocol interface > @param[in] FilePath Path of the file, Unicode encoded > @param[in] AsciiFilePath Path of the file, ASCII encoded > @param[in] FileSize Size of the file in number of bytes > @param[in] BlockSize Value of the TFTP blksize option > + @param[in] WindowSize Value of the TFTP window size option > @param[out] Data Address where to store the address of the = buffer > where the data of the file were downloaded= in > case of success. >=20 > @retval EFI_SUCCESS The file was downloaded. > @@ -904,10 +905,11 @@ Error : > @param[in] Mtftp4 MTFTP4 protocol interface > @param[in] FilePath Path of the file, Unicode encoded > @param[in] AsciiFilePath Path of the file, ASCII encoded > @param[in] FileSize Size of the file in number of bytes > @param[in] BlockSize Value of the TFTP blksize option > + @param[in] WindowSize Value of the TFTP window size option > @param[out] Data Address where to store the address of the = buffer > where the data of the file were downloaded= in > case of success. >=20 > @retval EFI_SUCCESS The file was downloaded. > -- > 2.17.1.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel