From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF80021167455 for ; Thu, 18 Oct 2018 07:17:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 07:17:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,396,1534834800"; d="scan'208";a="83646823" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 18 Oct 2018 07:17:55 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 18 Oct 2018 07:17:54 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.16]) by fmsmsx123.amr.corp.intel.com ([169.254.7.84]) with mapi id 14.03.0319.002; Thu, 18 Oct 2018 07:17:54 -0700 From: "Carsey, Jaben" To: "Feng, Bob C" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool. Thread-Index: AQHUZqWBI4Y3X40g2UepCNaWlM5386UlDWpQ Date: Thu, 18 Oct 2018 14:17:54 +0000 Message-ID: References: <20181018054319.20236-1-bob.c.feng@intel.com> In-Reply-To: <20181018054319.20236-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVjMDIwM2UtYWNkMi00OTQ3LTgwZDQtOTFjMDcxZDQwMTU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiemFnRU84YWZPN251RjArUWtKMkl0VzQ4SGFnNGxZd1dYd3ZFUTJBWnBaeHBYUVlyM28zSXhabm9kSG05WnUyMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 14:17:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > BobCF > Sent: Wednesday, October 17, 2018 10:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options for > PcdValueInit tool. >=20 > PcdValueInit tool is Arch independent, the Arch specific > build options should be removed from PcdValueInit makefile. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob C Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py > b/BaseTools/Source/Python/Workspace/DscBuildData.py > index 19ac71ac09..47f5033953 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject): > if Tool !=3D 'CC': > continue >=20 > if Target =3D=3D "*" or Target =3D=3D self._Target: > if Tag =3D=3D "*" or Tag =3D=3D self._Toolchain: > - if Arch =3D=3D "*" or Arch =3D=3D self.Arch: > + if Arch =3D=3D "*": > if Tool not in BuildOptions: > BuildOptions[Tool] =3D OrderedDict() > if Attr !=3D "FLAGS" or Attr not in BuildOptions= [Tool] or > self.BuildOptions[Options].startswith('=3D'): > BuildOptions[Tool][Attr] =3D self.BuildOptio= ns[Options] > else: > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel