* [Patch] BaseTools: Fix the bug that PcdValueFromComm is not set
@ 2018-10-19 7:26 Yonghong Zhu
2018-10-19 14:32 ` Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-10-19 7:26 UTC (permalink / raw)
To: edk2-devel
the bug is PcdValueFromComm is not set, but the Pcd have been override
by the command line option.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index e481ea4..17e6f62 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -1065,10 +1065,11 @@ class DscBuildData(PlatformBuildClassObject):
continue
for key in BuildData.Pcds:
PcdItem = BuildData.Pcds[key]
if (TokenSpaceGuidCName, TokenCName) == (PcdItem.TokenSpaceGuidCName, PcdItem.TokenCName) and FieldName =="":
PcdItem.DefaultValue = pcdvalue
+ PcdItem.PcdValueFromComm = pcdvalue
#In command line, the latter full assign value in commandLine should override the former field assign value.
#For example, --pcd Token.pcd.field="" --pcd Token.pcd=H"{}"
delete_assign = []
field_assign = {}
if GlobalData.BuildOptionPcd:
--
2.6.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Fix the bug that PcdValueFromComm is not set
2018-10-19 7:26 [Patch] BaseTools: Fix the bug that PcdValueFromComm is not set Yonghong Zhu
@ 2018-10-19 14:32 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2018-10-19 14:32 UTC (permalink / raw)
To: Zhu, Yonghong, edk2-devel@lists.01.org
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Friday, October 19, 2018 12:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix the bug that PcdValueFromComm is
> not set
>
> the bug is PcdValueFromComm is not set, but the Pcd have been override
> by the command line option.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
> b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index e481ea4..17e6f62 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -1065,10 +1065,11 @@ class DscBuildData(PlatformBuildClassObject):
> continue
> for key in BuildData.Pcds:
> PcdItem = BuildData.Pcds[key]
> if (TokenSpaceGuidCName, TokenCName) ==
> (PcdItem.TokenSpaceGuidCName, PcdItem.TokenCName) and FieldName
> =="":
> PcdItem.DefaultValue = pcdvalue
> + PcdItem.PcdValueFromComm = pcdvalue
> #In command line, the latter full assign value in commandLine should
> override the former field assign value.
> #For example, --pcd Token.pcd.field="" --pcd Token.pcd=H"{}"
> delete_assign = []
> field_assign = {}
> if GlobalData.BuildOptionPcd:
> --
> 2.6.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-19 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-19 7:26 [Patch] BaseTools: Fix the bug that PcdValueFromComm is not set Yonghong Zhu
2018-10-19 14:32 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox