From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 157A82194D387 for ; Thu, 15 Nov 2018 07:16:09 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 07:16:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,236,1539673200"; d="scan'208";a="249958998" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 15 Nov 2018 07:16:09 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 15 Nov 2018 07:16:08 -0800 Received: from fmsmsx101.amr.corp.intel.com ([169.254.1.202]) by FMSMSX114.amr.corp.intel.com ([169.254.6.69]) with mapi id 14.03.0415.000; Thu, 15 Nov 2018 07:16:08 -0800 From: "Carsey, Jaben" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Kacperski, Kamil" , "Jin, Eric" , "Orlowski, Pawel" , "Kinney, Michael D" , "Hsiung, Harry L" Thread-Topic: [edk2] [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference Thread-Index: AQHUfIvM+Z3q6g4eHki8F1aUzDj0IKVQ8w1w Date: Thu, 15 Nov 2018 15:16:08 +0000 Message-ID: References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-11-ard.biesheuvel@linaro.org> In-Reply-To: <20181115023353.20159-11-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWFlYTViODUtZTBmNS00N2FjLTgxY2UtN2M0MzA0MDI3ZDcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1A3ajlvMWVtQzJZbkd3NlNCK1JVYVwvSlZNa2R5ZlZWMzcyYVRnOTJJSnpmK3diRnlkUUpxVWhsVXVMeXpHTEsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 15:16:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agreed. =20 Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Wednesday, November 14, 2018 6:34 PM > To: edk2-devel@lists.01.org > Cc: Kacperski, Kamil ; Jin, Eric > ; Orlowski, Pawel ; Kinney, > Michael D ; Hsiung, Harry L > > Subject: [edk2] [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop > StdLibC library class reference > Importance: High >=20 > StdLibc should not be used in drivers (it has dependencies on Shell > protocols), but in fact, we don't appear to rely on it in the first > place, so just drop the reference. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > index beee8aa8134e..b5747565fbea 100644 > --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > @@ -132,7 +132,6 @@ GCC:*_*_*_CC_FLAGS =3D -DEFI32 > PrintLib > UefiLib > HiiLib > - StdLibC >=20 > [LibraryClasses.X64] >=20 > -- > 2.17.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel