From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B3E32118C4EA for ; Thu, 15 Nov 2018 07:18:46 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 07:18:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,236,1539673200"; d="scan'208";a="249959583" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 15 Nov 2018 07:18:45 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 15 Nov 2018 07:18:45 -0800 Received: from fmsmsx101.amr.corp.intel.com ([169.254.1.202]) by fmsmsx158.amr.corp.intel.com ([169.254.15.234]) with mapi id 14.03.0415.000; Thu, 15 Nov 2018 07:18:44 -0800 From: "Carsey, Jaben" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , Leif Lindholm , Ard Biesheuvel Thread-Topic: [PATCH] ShellPkg: Remove ShellPkg wrapper header files Thread-Index: AQHUfLc4GbD681c8vUa8jcwSLaiZLqVQ84eQ Date: Thu, 15 Nov 2018 15:18:44 +0000 Message-ID: References: <20181115074528.8024-1-shenglei.zhang@intel.com> In-Reply-To: <20181115074528.8024-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDMwOWNmN2UtMDQwNS00YWRmLTk3ZjgtZjZkNWQ1NTZmOWIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGFUVjFoS2tqd2pKWHFQQk8waG4zRk1YY095N1YzYVIxeHU0ZlVtdXppektVZkZreTUrZmNrTjUySWVHOTNOMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Remove ShellPkg wrapper header files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 15:18:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, November 14, 2018 11:45 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > ; Leif Lindholm ; Ard > Biesheuvel > Subject: [PATCH] ShellPkg: Remove ShellPkg wrapper header files > Importance: High >=20 > These wrapper header files are not referenced by all > open source, so they are removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D158 >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Include/Protocol/EfiShell.h | 21 ------------------- > .../Include/Protocol/EfiShellDynamicCommand.h | 21 ------------------- > .../Include/Protocol/EfiShellParameters.h | 20 ------------------ > ShellPkg/Include/ShellBase.h | 20 ------------------ > 4 files changed, 82 deletions(-) > delete mode 100644 ShellPkg/Include/Protocol/EfiShell.h > delete mode 100644 ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > delete mode 100644 ShellPkg/Include/Protocol/EfiShellParameters.h > delete mode 100644 ShellPkg/Include/ShellBase.h >=20 > diff --git a/ShellPkg/Include/Protocol/EfiShell.h > b/ShellPkg/Include/Protocol/EfiShell.h > deleted file mode 100644 > index 8e3c2fe4de..0000000000 > --- a/ShellPkg/Include/Protocol/EfiShell.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/** @file > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification incl= uding > errata. > - > - (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the = BSD > License > - which accompanies this distribution. The full text of the license may= be > found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ > -#define __EFI_SHELL_PROTOCOL_H__WRAPPER__ > - > -#include > - > -#endif > diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > deleted file mode 100644 > index 50f9398ec6..0000000000 > --- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/** @file > - EFI Shell Dynamic Command registration protocol > - > - (C) Copyright 2012-2014 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the = BSD > License > - which accompanies this distribution. The full text of the license may= be > found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > -#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > - > -#include > - > -#endif > diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h > b/ShellPkg/Include/Protocol/EfiShellParameters.h > deleted file mode 100644 > index 184b029ffa..0000000000 > --- a/ShellPkg/Include/Protocol/EfiShellParameters.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/** @file > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification. > - > - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the = BSD > License > - which accompanies this distribution. The full text of the license may= be > found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > -#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > - > -#include > - > -#endif > diff --git a/ShellPkg/Include/ShellBase.h b/ShellPkg/Include/ShellBase.h > deleted file mode 100644 > index 725ce5242f..0000000000 > --- a/ShellPkg/Include/ShellBase.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/** @file > - Root include file for Shell Package modules that utilize the SHELL_RET= URN > type > - > - Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the = BSD > License > - which accompanies this distribution. The full text of the license may= be > found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef _SHELL_BASE_ > -#define _SHELL_BASE_ > - > -#include > - > -#endif //__SHELL_BASE_ > -- > 2.18.0.windows.1