From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [Patch v1 1/1] BaseTools: Move Identification file to Eot
Date: Tue, 27 Nov 2018 18:02:36 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA715A9A0@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <f52d0c175c0916a4fb3fbc04ea15ab12f9fb8a55.1542382934.git.jaben.carsey@intel.com>
Poke. Any comments on this one?
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Friday, November 16, 2018 7:42 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch v1 1/1] BaseTools: Move Identification file to Eot
> Importance: High
>
> Move the Identification file.
> This file is only ever imported into the Eot tool.
>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
> ---
> BaseTools/Source/Python/{Common => Eot}/Identification.py | 0
> BaseTools/Source/Python/Eot/InfParserLite.py | 3 ++-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/Common/Identification.py
> b/BaseTools/Source/Python/Eot/Identification.py
> similarity index 100%
> rename from BaseTools/Source/Python/Common/Identification.py
> rename to BaseTools/Source/Python/Eot/Identification.py
> diff --git a/BaseTools/Source/Python/Eot/InfParserLite.py
> b/BaseTools/Source/Python/Eot/InfParserLite.py
> index c910c129a719..0cfe0398f05f 100644
> --- a/BaseTools/Source/Python/Eot/InfParserLite.py
> +++ b/BaseTools/Source/Python/Eot/InfParserLite.py
> @@ -16,11 +16,12 @@
> #
> from __future__ import print_function
> from __future__ import absolute_import
> +
> import Common.LongFilePathOs as os
> import Common.EdkLogger as EdkLogger
> from Common.DataType import *
> from CommonDataClass.DataClass import *
> -from Common.Identification import *
> +from Eot.Identification import Identification
> from Common.StringUtils import *
> from Eot.Parser import *
> from Eot import Database
> --
> 2.16.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-11-27 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1542382934.git.jaben.carsey@intel.com>
2018-11-16 15:42 ` [Patch v1 1/1] BaseTools: Move Identification file to Eot Jaben Carsey
2018-11-27 18:02 ` Carsey, Jaben [this message]
2018-11-28 7:29 ` Feng, Bob C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA715A9A0@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox