public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch v1 1/1] BaseTools: Move Identification file to Eot
       [not found] <cover.1542382934.git.jaben.carsey@intel.com>
@ 2018-11-16 15:42 ` Jaben Carsey
  2018-11-27 18:02   ` Carsey, Jaben
  2018-11-28  7:29   ` Feng, Bob C
  0 siblings, 2 replies; 3+ messages in thread
From: Jaben Carsey @ 2018-11-16 15:42 UTC (permalink / raw)
  To: edk2-devel; +Cc: Yonghong Zhu, Liming Gao

Move the Identification file.
This file is only ever imported into the Eot tool.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/{Common => Eot}/Identification.py | 0
 BaseTools/Source/Python/Eot/InfParserLite.py              | 3 ++-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/Common/Identification.py b/BaseTools/Source/Python/Eot/Identification.py
similarity index 100%
rename from BaseTools/Source/Python/Common/Identification.py
rename to BaseTools/Source/Python/Eot/Identification.py
diff --git a/BaseTools/Source/Python/Eot/InfParserLite.py b/BaseTools/Source/Python/Eot/InfParserLite.py
index c910c129a719..0cfe0398f05f 100644
--- a/BaseTools/Source/Python/Eot/InfParserLite.py
+++ b/BaseTools/Source/Python/Eot/InfParserLite.py
@@ -16,11 +16,12 @@
 #
 from __future__ import print_function
 from __future__ import absolute_import
+
 import Common.LongFilePathOs as os
 import Common.EdkLogger as EdkLogger
 from Common.DataType import *
 from CommonDataClass.DataClass import *
-from Common.Identification import *
+from Eot.Identification import Identification
 from Common.StringUtils import *
 from Eot.Parser import *
 from Eot import Database
-- 
2.16.2.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Patch v1 1/1] BaseTools: Move Identification file to Eot
  2018-11-16 15:42 ` [Patch v1 1/1] BaseTools: Move Identification file to Eot Jaben Carsey
@ 2018-11-27 18:02   ` Carsey, Jaben
  2018-11-28  7:29   ` Feng, Bob C
  1 sibling, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2018-11-27 18:02 UTC (permalink / raw)
  To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Gao, Liming, Zhu, Yonghong

Poke.  Any comments on this one?

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Friday, November 16, 2018 7:42 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch v1 1/1] BaseTools: Move Identification file to Eot
> Importance: High
> 
> Move the Identification file.
> This file is only ever imported into the Eot tool.
> 
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  BaseTools/Source/Python/{Common => Eot}/Identification.py | 0
>  BaseTools/Source/Python/Eot/InfParserLite.py              | 3 ++-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/Common/Identification.py
> b/BaseTools/Source/Python/Eot/Identification.py
> similarity index 100%
> rename from BaseTools/Source/Python/Common/Identification.py
> rename to BaseTools/Source/Python/Eot/Identification.py
> diff --git a/BaseTools/Source/Python/Eot/InfParserLite.py
> b/BaseTools/Source/Python/Eot/InfParserLite.py
> index c910c129a719..0cfe0398f05f 100644
> --- a/BaseTools/Source/Python/Eot/InfParserLite.py
> +++ b/BaseTools/Source/Python/Eot/InfParserLite.py
> @@ -16,11 +16,12 @@
>  #
>  from __future__ import print_function
>  from __future__ import absolute_import
> +
>  import Common.LongFilePathOs as os
>  import Common.EdkLogger as EdkLogger
>  from Common.DataType import *
>  from CommonDataClass.DataClass import *
> -from Common.Identification import *
> +from Eot.Identification import Identification
>  from Common.StringUtils import *
>  from Eot.Parser import *
>  from Eot import Database
> --
> 2.16.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Patch v1 1/1] BaseTools: Move Identification file to Eot
  2018-11-16 15:42 ` [Patch v1 1/1] BaseTools: Move Identification file to Eot Jaben Carsey
  2018-11-27 18:02   ` Carsey, Jaben
@ 2018-11-28  7:29   ` Feng, Bob C
  1 sibling, 0 replies; 3+ messages in thread
From: Feng, Bob C @ 2018-11-28  7:29 UTC (permalink / raw)
  To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Gao, Liming

Reviewed-by : Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Friday, November 16, 2018 11:42 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>
Subject: [edk2] [Patch v1 1/1] BaseTools: Move Identification file to Eot

Move the Identification file.
This file is only ever imported into the Eot tool.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/{Common => Eot}/Identification.py | 0
 BaseTools/Source/Python/Eot/InfParserLite.py              | 3 ++-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/Common/Identification.py b/BaseTools/Source/Python/Eot/Identification.py
similarity index 100%
rename from BaseTools/Source/Python/Common/Identification.py
rename to BaseTools/Source/Python/Eot/Identification.py
diff --git a/BaseTools/Source/Python/Eot/InfParserLite.py b/BaseTools/Source/Python/Eot/InfParserLite.py
index c910c129a719..0cfe0398f05f 100644
--- a/BaseTools/Source/Python/Eot/InfParserLite.py
+++ b/BaseTools/Source/Python/Eot/InfParserLite.py
@@ -16,11 +16,12 @@
 #
 from __future__ import print_function
 from __future__ import absolute_import
+
 import Common.LongFilePathOs as os
 import Common.EdkLogger as EdkLogger
 from Common.DataType import *
 from CommonDataClass.DataClass import * -from Common.Identification import *
+from Eot.Identification import Identification
 from Common.StringUtils import *
 from Eot.Parser import *
 from Eot import Database
--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-28  7:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1542382934.git.jaben.carsey@intel.com>
2018-11-16 15:42 ` [Patch v1 1/1] BaseTools: Move Identification file to Eot Jaben Carsey
2018-11-27 18:02   ` Carsey, Jaben
2018-11-28  7:29   ` Feng, Bob C

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox