From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4F03E21195BFA for ; Tue, 27 Nov 2018 10:03:19 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2018 10:03:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,287,1539673200"; d="scan'208";a="93938850" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 27 Nov 2018 10:03:06 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.186]) by fmsmsx107.amr.corp.intel.com ([169.254.6.67]) with mapi id 14.03.0415.000; Tue, 27 Nov 2018 10:03:06 -0800 From: "Carsey, Jaben" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [edk2] [Patch v1 1/1] BaseTools: cleanup LongFilePathSupport usage Thread-Index: AQHUfcJ1QU5obcSjY0KiHpDORPwwmqVj+1Uw Date: Tue, 27 Nov 2018 18:03:05 +0000 Message-ID: References: <3a9ca307682f748e567e496d5370c30d8f609105.1542382689.git.jaben.carsey@intel.com> In-Reply-To: <3a9ca307682f748e567e496d5370c30d8f609105.1542382689.git.jaben.carsey@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJkNWYyMzMtMzBjYy00NWZjLTk0YjgtZmVkMWQ2OTIxNjkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNnIwcURWSHdwa21aN01GUzRNcU4wZ081SWlqcU5RMkhsS0dhSlwvNDJ3YmE4VnJDRWZ5eDBIbndpK1BcL2lSK2paIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [Patch v1 1/1] BaseTools: cleanup LongFilePathSupport usage X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 18:03:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Poke. Any comments on this one? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jaben Carsey > Sent: Friday, November 16, 2018 7:38 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch v1 1/1] BaseTools: cleanup LongFilePathSupport usa= ge >=20 > 1) remove an identical function and import it from > Common.LongFilePathSupport > 2) remove an import that is not needed/used. >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jaben Carsey > --- > BaseTools/Source/Python/AutoGen/UniClassObject.py | 14 +------------- > BaseTools/Source/Python/build/build.py | 1 - > 2 files changed, 1 insertion(+), 14 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/UniClassObject.py > b/BaseTools/Source/Python/AutoGen/UniClassObject.py > index 384f31b165de..764d95ec660b 100644 > --- a/BaseTools/Source/Python/AutoGen/UniClassObject.py > +++ b/BaseTools/Source/Python/AutoGen/UniClassObject.py > @@ -24,7 +24,7 @@ from io import BytesIO > from Common.BuildToolError import * > from Common.StringUtils import GetLineNo > from Common.Misc import PathClass > -from Common.LongFilePathSupport import LongFilePath > +from Common.LongFilePathSupport import LongFilePath, UniToStr > from Common.GlobalData import * > ## > # Static definitions > @@ -46,18 +46,6 @@ BACK_SLASH_PLACEHOLDER =3D u'\u0006' >=20 > gIncludePattern =3D re.compile("^#include +[\"<]+([^\"< >]+)[>\"]+$", > re.MULTILINE | re.UNICODE) >=20 > -## Convert a python unicode string to a normal string > -# > -# Convert a python unicode string to a normal string > -# UniToStr(u'I am a string') is 'I am a string' > -# > -# @param Uni: The python unicode string > -# > -# @retval: The formatted normal string > -# > -def UniToStr(Uni): > - return repr(Uni)[2:-1] > - > ## Convert a unicode string to a Hex list > # > # Convert a unicode string to a Hex list > diff --git a/BaseTools/Source/Python/build/build.py > b/BaseTools/Source/Python/build/build.py > index d74082fc2666..5eeb626cfbbb 100644 > --- a/BaseTools/Source/Python/build/build.py > +++ b/BaseTools/Source/Python/build/build.py > @@ -36,7 +36,6 @@ from subprocess import * > from Common import Misc as Utils >=20 > from Common.LongFilePathSupport import OpenLongFilePath as open > -from Common.LongFilePathSupport import LongFilePath > from Common.TargetTxtClassObject import * > from Common.ToolDefClassObject import * > from Common.DataType import * > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel