From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 38F5721959CB2 for ; Mon, 31 Dec 2018 13:22:10 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Dec 2018 13:22:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,424,1539673200"; d="scan'208";a="263487921" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 31 Dec 2018 13:22:09 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.148]) by fmsmsx107.amr.corp.intel.com ([169.254.6.248]) with mapi id 14.03.0415.000; Mon, 31 Dec 2018 13:22:09 -0800 From: "Carsey, Jaben" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH v4 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper Thread-Index: AQHUnCpI6V85Omgt7kqXKQklUuDWtqWZZQsg Date: Mon, 31 Dec 2018 21:22:08 +0000 Message-ID: References: <20181225081717.2776-1-shenglei.zhang@intel.com> <20181225081717.2776-7-shenglei.zhang@intel.com> In-Reply-To: <20181225081717.2776-7-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGMxNWQ1NWMtMDVjMS00NWRlLThiZmMtNTllMTFkYzRhNTY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK3ZIcTVRZE9RM3VQQmcxdGhVNHJ5aXQ3cGNmU3JsdDRReGJFeVhnNFRaWENqcFUwMCswSUV5NGl5Vk8wXC8xR2cifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v4 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2018 21:22:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, December 25, 2018 12:17 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [PATCH v4 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper > Importance: High >=20 > Substitute InternalShellCharToUpper with a public function > CharToUpper which has the same function. > Remove the implement of InternalShellCharToUpper. >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Application/Shell/ShellManParser.c | 23 +-------------------- > 1 file changed, 1 insertion(+), 22 deletions(-) >=20 > diff --git a/ShellPkg/Application/Shell/ShellManParser.c > b/ShellPkg/Application/Shell/ShellManParser.c > index b180c6c8f7..2c044dbe4a 100644 > --- a/ShellPkg/Application/Shell/ShellManParser.c > +++ b/ShellPkg/Application/Shell/ShellManParser.c > @@ -46,27 +46,6 @@ SHELL_MAN_HII_VENDOR_DEVICE_PATH > mShellManHiiDevicePath =3D { > } > }; >=20 > - > -/** > - Convert a Unicode character to upper case only if > - it maps to a valid small-case ASCII character. > - > - This internal function only deal with Unicode character > - which maps to a valid small-case ASCII character, i.e. > - L'a' to L'z'. For other Unicode character, the input character > - is returned directly. > - > - @param Char The character to convert. > - > - @retval LowerCharacter If the Char is with range L'a' to L'z'. > - @retval Unchanged Otherwise. > - > -**/ > -CHAR16 > -InternalShellCharToUpper ( > - IN CHAR16 Char > - ); > - > /** > Verifies that the filename has .EFI on the end. >=20 > @@ -416,7 +395,7 @@ IsTitleHeader( > ReturnFound =3D TRUE; // This is the desired command's title = header line. > State =3D (BriefDesc =3D=3D NULL) ? Final : GetBriefDescriptio= n; > } > - else if (InternalShellCharToUpper (*Line) !=3D InternalShellChar= ToUpper > (*(Command + CommandIndex++))) { > + else if (CharToUpper (*Line) !=3D CharToUpper (*(Command + > CommandIndex++))) { > State =3D Final; > } > Line++; > -- > 2.18.0.windows.1