From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B43B211A1E30 for ; Wed, 2 Jan 2019 11:28:05 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2019 11:28:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,432,1539673200"; d="scan'208";a="122844899" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 02 Jan 2019 11:28:04 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 2 Jan 2019 11:28:04 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.197]) by fmsmsx158.amr.corp.intel.com ([169.254.15.41]) with mapi id 14.03.0415.000; Wed, 2 Jan 2019 11:28:04 -0800 From: "Carsey, Jaben" To: Alex James , "edk2-devel@lists.01.org" CC: Daryl McDaniel Thread-Topic: [PATCH v1 2/2] StdLib/Environs: Avoid infinite recursion in _Exit Thread-Index: AQHUlomxAf+7i46yP0+GsHGZ+rGxIKWcdWsA Date: Wed, 2 Jan 2019 19:28:03 +0000 Message-ID: References: <20181218042513.43232-1-theracermaster@gmail.com> <20181218042513.43232-3-theracermaster@gmail.com> In-Reply-To: <20181218042513.43232-3-theracermaster@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjQ3MmI2YTEtYWJlOS00YzE2LTg3MjktYzc0YWRlOTJjZTQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRUZwdjIxaWtueFJOZ1lIR1wvSjI0ZGM2WlFlR2NudmZUeEFoRnNZdlFGNzNcL0lFVFlxbkZmc3dlblRmb0ZuS1NvIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v1 2/2] StdLib/Environs: Avoid infinite recursion in _Exit X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 19:28:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey And pushed. > -----Original Message----- > From: Alex James [mailto:theracermaster@gmail.com] > Sent: Monday, December 17, 2018 8:25 PM > To: edk2-devel@lists.01.org > Cc: Daryl McDaniel ; Carsey, Jaben > > Subject: [PATCH v1 2/2] StdLib/Environs: Avoid infinite recursion in _Exi= t > Importance: High >=20 > Use __builtin_unreachable instead of infinite recursion to fix an > infinite recursion error when building StdLib with XCODE5/CLANG38. >=20 > Cc: Daryl McDaniel > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alex James > --- > StdLib/LibC/StdLib/Environs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/StdLib/LibC/StdLib/Environs.c b/StdLib/LibC/StdLib/Environs.= c > index 15221a1260..a29cb9954c 100644 > --- a/StdLib/LibC/StdLib/Environs.c > +++ b/StdLib/LibC/StdLib/Environs.c > @@ -120,7 +120,7 @@ _Exit(int status) > longjmp(gMD->MainExit, 0x55); // Get out of here. longjmp can't r= eturn > 0. Use 0x55 for a non-zero value. >=20 > #ifdef __GNUC__ > - _Exit(status); /* Keep GCC happy - never reached */ > + __builtin_unreachable (); // Keep GCC happy > #endif > } >=20 > -- > 2.20.1