* [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
@ 2019-01-09 8:34 BobCF
2019-01-09 18:52 ` Carsey, Jaben
2019-01-14 0:04 ` Gao, Liming
0 siblings, 2 replies; 3+ messages in thread
From: BobCF @ 2019-01-09 8:34 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng, Bob C, Liming Gao, Jaben Carsey
From: "Feng, Bob C" <bob.c.feng@intel.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=1350
Remove ECP support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
index d7c5f0c858..873ce69094 100644
--- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
+++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
@@ -178,11 +178,10 @@ typedef struct {
#define PCI_IF_16850 0x05
#define PCI_IF_16950 0x06
#define PCI_SUBCLASS_PARALLEL 0x01
#define PCI_IF_PARALLEL_PORT 0x00
#define PCI_IF_BI_DIR_PARALLEL_PORT 0x01
-#define PCI_IF_ECP_PARALLEL_PORT 0x02
#define PCI_IF_1284_CONTROLLER 0x03
#define PCI_IF_1284_DEVICE 0xFE
#define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02
#define PCI_SUBCLASS_MODEM 0x03
#define PCI_IF_GENERIC_MODEM 0x00
--
2.19.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
2019-01-09 8:34 [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools BobCF
@ 2019-01-09 18:52 ` Carsey, Jaben
2019-01-14 0:04 ` Gao, Liming
1 sibling, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2019-01-09 18:52 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org; +Cc: Gao, Liming
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, January 09, 2019 12:35 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C
> tools
> Importance: High
>
> From: "Feng, Bob C" <bob.c.feng@intel.com>
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1350
> Remove ECP support from BaseTools C code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
> b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
> index d7c5f0c858..873ce69094 100644
> --- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
> +++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
> @@ -178,11 +178,10 @@ typedef struct {
> #define PCI_IF_16850 0x05
> #define PCI_IF_16950 0x06
> #define PCI_SUBCLASS_PARALLEL 0x01
> #define PCI_IF_PARALLEL_PORT 0x00
> #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01
> -#define PCI_IF_ECP_PARALLEL_PORT 0x02
> #define PCI_IF_1284_CONTROLLER 0x03
> #define PCI_IF_1284_DEVICE 0xFE
> #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02
> #define PCI_SUBCLASS_MODEM 0x03
> #define PCI_IF_GENERIC_MODEM 0x00
> --
> 2.19.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
2019-01-09 8:34 [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools BobCF
2019-01-09 18:52 ` Carsey, Jaben
@ 2019-01-14 0:04 ` Gao, Liming
1 sibling, 0 replies; 3+ messages in thread
From: Gao, Liming @ 2019-01-14 0:04 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Bob:
This change is not related to ECP. Please keep this definition.
>-----Original Message-----
>From: Feng, Bob C
>Sent: Wednesday, January 09, 2019 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
>Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C
>tools
>
>From: "Feng, Bob C" <bob.c.feng@intel.com>
>
>https://bugzilla.tianocore.org/show_bug.cgi?id=1350
>Remove ECP support from BaseTools C code.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Jaben Carsey <jaben.carsey@intel.com>
>---
> BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>index d7c5f0c858..873ce69094 100644
>--- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>+++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>@@ -178,11 +178,10 @@ typedef struct {
> #define PCI_IF_16850 0x05
> #define PCI_IF_16950 0x06
> #define PCI_SUBCLASS_PARALLEL 0x01
> #define PCI_IF_PARALLEL_PORT 0x00
> #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01
>-#define PCI_IF_ECP_PARALLEL_PORT 0x02
> #define PCI_IF_1284_CONTROLLER 0x03
> #define PCI_IF_1284_DEVICE 0xFE
> #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02
> #define PCI_SUBCLASS_MODEM 0x03
> #define PCI_IF_GENERIC_MODEM 0x00
>--
>2.19.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 0:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-09 8:34 [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools BobCF
2019-01-09 18:52 ` Carsey, Jaben
2019-01-14 0:04 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox