From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 80D4B211B113F for ; Wed, 9 Jan 2019 10:52:19 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 10:52:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,458,1539673200"; d="scan'208";a="106972549" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 09 Jan 2019 10:52:18 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 9 Jan 2019 10:52:18 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.197]) by fmsmsx124.amr.corp.intel.com ([169.254.8.80]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 10:52:18 -0800 From: "Carsey, Jaben" To: "Feng, Bob C" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools Thread-Index: AQHUp/Y7sQ522m/o0Euz+MikM2de46WnSPDA Date: Wed, 9 Jan 2019 18:52:17 +0000 Message-ID: References: <20190109083455.60404-1-bob.c.feng@intel.com> In-Reply-To: <20190109083455.60404-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI4OGJmMTQtZjlmMi00OTJhLTk3NzMtODFmMGQ2NTQ4Mjg4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTis0d2FLQ1hiUGs4ZEM2czN0Um9BNmRGc1FTcng1R0ZkaGx3UFA5bG5oZ1ZcL2ZqbWd6ZDdyaTRcLzNxcm9TSFE4In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 18:52:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, January 09, 2019 12:35 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > ; Carsey, Jaben > Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C > tools > Importance: High >=20 > From: "Feng, Bob C" >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1350 > Remove ECP support from BaseTools C code. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Jaben Carsey > --- > BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h > b/BaseTools/Source/C/Include/IndustryStandard/pci22.h > index d7c5f0c858..873ce69094 100644 > --- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h > +++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h > @@ -178,11 +178,10 @@ typedef struct { > #define PCI_IF_16850 0x05 > #define PCI_IF_16950 0x06 > #define PCI_SUBCLASS_PARALLEL 0x01 > #define PCI_IF_PARALLEL_PORT 0x00 > #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01 > -#define PCI_IF_ECP_PARALLEL_PORT 0x02 > #define PCI_IF_1284_CONTROLLER 0x03 > #define PCI_IF_1284_DEVICE 0xFE > #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02 > #define PCI_SUBCLASS_MODEM 0x03 > #define PCI_IF_GENERIC_MODEM 0x00 > -- > 2.19.1.windows.1