From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 758C021BADAB2 for ; Fri, 25 Jan 2019 08:10:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2019 08:10:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,521,1539673200"; d="scan'208";a="314827368" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 25 Jan 2019 08:10:49 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 25 Jan 2019 08:10:49 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.205]) by fmsmsx115.amr.corp.intel.com ([169.254.4.199]) with mapi id 14.03.0415.000; Fri, 25 Jan 2019 08:10:49 -0800 From: "Carsey, Jaben" To: "Li, Songpeng" , Vladimir Olovyannikov , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper status Thread-Index: AQHUs0lUS1tTU1O9jkqQo8iazWkqnaW/94SAgAAy1tA= Date: Fri, 25 Jan 2019 16:10:48 +0000 Message-ID: References: <20190123182615.3184-1-vladimir.olovyannikov@broadcom.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTliZGIzNTItNTY1Yi00ZTQ2LWE5ZDgtNDY3NzllZTAwYzhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC81ZElPWFVWSzZ2eWRjWnR5SVRLQk5aWDVWUFRGaXBPd1J6MXRPaDRkMm1MOUxqcUxjcFdVdWhEVGVYbDFnVXEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/TftpDynamicCommand: Return proper status X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 16:10:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey And pushed with the BZ added to commit REF. > -----Original Message----- > From: Li, Songpeng > Sent: Thursday, January 24, 2019 9:08 PM > To: Vladimir Olovyannikov ; edk2- > devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper > status > Importance: High >=20 > Reviewed-by: Songpeng Li >=20 > Sorry, the previous email did not include edk2 mailing list. >=20 > Best, > Songpeng >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Vladimir Olovyannikov via edk2-devel > > Sent: Thursday, January 24, 2019 2:26 AM > > To: Carsey, Jaben ; Ni, Ray ; > > edk2-devel@lists.01.org > > Cc: Vladimir Olovyannikov > > Subject: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper > > status > > > > Tftp command always returned "SHELL_NOT_FOUND" which is treated as > an > > error by callers. Add missing line to clean the ShellStatus on > > successful operation. If operation has failed, return the error status > > if available. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Vladimir Olovyannikov > > > > --- > > ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > > b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > > index ba753a279b00..88e3988a554e 100644 > > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > > @@ -548,6 +548,8 @@ RunTftp ( > > goto NextHandle; > > } > > > > + ShellStatus =3D SHELL_SUCCESS; > > + > > NextHandle: > > > > CloseProtocolAndDestroyServiceChild ( > > @@ -575,6 +577,10 @@ RunTftp ( > > FreePool (Handles); > > } > > > > + if ((ShellStatus !=3D SHELL_SUCCESS) && (EFI_ERROR(Status))) { > > + ShellStatus =3D Status & ~MAX_BIT; > > + } > > + > > return ShellStatus; > > } > > > > -- > > 2.20.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel