From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0EDF2117D75A for ; Mon, 28 Jan 2019 07:21:20 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2019 07:21:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,534,1539673200"; d="scan'208";a="113300793" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 28 Jan 2019 07:21:19 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 28 Jan 2019 07:21:19 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.205]) by FMSMSX154.amr.corp.intel.com ([169.254.6.237]) with mapi id 14.03.0415.000; Mon, 28 Jan 2019 07:21:19 -0800 From: "Carsey, Jaben" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain build failure Thread-Index: AQHUtrmmefQSNzCvSkGvQzk/H/cU5qXEzMLw Date: Mon, 28 Jan 2019 15:21:18 +0000 Message-ID: References: <20190128032850.13068-1-dandan.bi@intel.com> In-Reply-To: <20190128032850.13068-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjgxYmMwMmMtOGJkNS00N2RlLWI0YWItMzI5YjU1OWUyYTUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWkF0S2JkZm0xOUFucFF6bUltRlNaOXk1R0RJalhrQ1pIUUFFOWxHemNvUGlDSjhtcGt0NURocjNNQ1l6K1p3ZyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 15:21:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Bi, Dandan > Sent: Sunday, January 27, 2019 7:29 PM > To: edk2-devel@lists.01.org > Cc: Krzysztof Koch ; Carsey, Jaben > ; Ni, Ray > Subject: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain > build failure > Importance: High >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1491 >=20 > This patch is to update the data type of variable "Offset" > from UINT8 to UINT32 to fix following build issue. >=20 > ...\Parsers\Pptt\PpttParser.c(193): error C2220: > warning treated as error - no 'object' file generated > ...\Parsers\Pptt\PpttParser.c(193): warning C4244: '=3D': > conversion from 'UINT32' to 'UINT8', possible loss of data >=20 > Cc: Krzysztof Koch > Cc: Jaben Carsey > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > .../UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > index d97ddf8e92..bc56fe9ea1 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > @@ -176,11 +176,11 @@ VOID > DumpProcessorHierarchyNodeStructure ( > IN UINT8* Ptr, > IN UINT8 Length > ) > { > - UINT8 Offset; > + UINT32 Offset; > UINT8* PrivateResourcePtr; > UINT32 Index; > CHAR16 Buffer[OUTPUT_FIELD_COLUMN_WIDTH]; >=20 > Offset =3D ParseAcpi ( > -- > 2.18.0.windows.1