[patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain build failure

[patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain build failure

[Dandan Bi]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1491

This patch is to update the data type of variable "Offset"
from UINT8 to UINT32 to fix following build issue.

...\Parsers\Pptt\PpttParser.c(193): error C2220:
warning treated as error - no 'object' file generated
...\Parsers\Pptt\PpttParser.c(193): warning C4244: '=':
conversion from 'UINT32' to 'UINT8', possible loss of data

Cc: Krzysztof Koch <krzysztof.koch@arm.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index d97ddf8e92..bc56fe9ea1 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
@@ -176,11 +176,11 @@ VOID
 DumpProcessorHierarchyNodeStructure (
   IN UINT8* Ptr,
   IN UINT8  Length
   )
 {
-  UINT8  Offset;
+  UINT32 Offset;
   UINT8* PrivateResourcePtr;
   UINT32 Index;
   CHAR16 Buffer[OUTPUT_FIELD_COLUMN_WIDTH];
 
   Offset = ParseAcpi (
-- 
2.18.0.windows.1

Re: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain build failure

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, January 27, 2019 7:29 PM
> To: edk2-devel@lists.01.org
> Cc: Krzysztof Koch <krzysztof.koch@arm.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain
> build failure
> Importance: High
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1491
> 
> This patch is to update the data type of variable "Offset"
> from UINT8 to UINT32 to fix following build issue.
> 
> ...\Parsers\Pptt\PpttParser.c(193): error C2220:
> warning treated as error - no 'object' file generated
> ...\Parsers\Pptt\PpttParser.c(193): warning C4244: '=':
> conversion from 'UINT32' to 'UINT8', possible loss of data
> 
> Cc: Krzysztof Koch <krzysztof.koch@arm.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  .../UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> index d97ddf8e92..bc56fe9ea1 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> @@ -176,11 +176,11 @@ VOID
>  DumpProcessorHierarchyNodeStructure (
>    IN UINT8* Ptr,
>    IN UINT8  Length
>    )
>  {
> -  UINT8  Offset;
> +  UINT32 Offset;
>    UINT8* PrivateResourcePtr;
>    UINT32 Index;
>    CHAR16 Buffer[OUTPUT_FIELD_COLUMN_WIDTH];
> 
>    Offset = ParseAcpi (
> --
> 2.18.0.windows.1