From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 099202096964D for ; Mon, 4 Feb 2019 07:27:11 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2019 07:27:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,560,1539673200"; d="scan'208";a="121877489" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga008.fm.intel.com with ESMTP; 04 Feb 2019 07:27:10 -0800 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 4 Feb 2019 07:27:09 -0800 Received: from orsmsx153.amr.corp.intel.com ([169.254.12.50]) by ORSMSX115.amr.corp.intel.com ([169.254.4.145]) with mapi id 14.03.0415.000; Mon, 4 Feb 2019 07:27:09 -0800 From: "Carsey, Jaben" To: Leif Lindholm , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , Daryl McDaniel Thread-Topic: [edk2] [PATCH v2] AppPkg: fix webserver build for !Ia32/X64 Thread-Index: AQHUcpnZwQiqbHLhLUiLbeZrdy+ivaXQpHcA//+yVDA= Date: Mon, 4 Feb 2019 15:27:08 +0000 Message-ID: References: <20181102105015.3609-1-leif.lindholm@linaro.org> <20190204120428.fuvr2hv2ts2yyxrp@bivouac.eciton.net> In-Reply-To: <20190204120428.fuvr2hv2ts2yyxrp@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDg2MGRmODYtZTNiMS00NDdiLWI2N2UtMjRiOWYyZTEwNGQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidzR0OFlcLzhHS1dLUkVGZUQyMlFwSkhHYzAwTlYrcFE5SEl0bGl3MHNcL2NUYnhlTDdmbmZhS3A2YjNjZ2xLd0k3In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH v2] AppPkg: fix webserver build for !Ia32/X64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 15:27:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Sorry, I missed this one. Code change here looks good. Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Leif Lindholm > Sent: Monday, February 04, 2019 4:04 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Carsey, Jaben > ; Daryl McDaniel > Subject: Re: [edk2] [PATCH v2] AppPkg: fix webserver build for !Ia32/X64 > Importance: High >=20 > Mike, Daryl, Jaben - any comments on v2? >=20 > On Fri, Nov 02, 2018 at 10:50:15AM +0000, Leif Lindholm wrote: > > The WebServer application is not meant to be Ia32/X64 specific, and wou= ld > > build for other architectures, if it wasn't for the > > #include > > in WebServer.h. Move that statement to Mtrr.c instead, which is the onl= y > > consumer, and is already being filtered out for other architectures. > > > > Cc: Daryl McDaniel > > Cc: Jaben Carsey > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > --- > > > > Resending only 1/6, since the others got R-b already. > > Looking at PageList.c, the app was clearly intended to be portable, > > so updated commit message to reflect this. > > > > AppPkg/Applications/Sockets/WebServer/WebServer.h | 1 - > > AppPkg/Applications/Sockets/WebServer/Mtrr.c | 1 + > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/AppPkg/Applications/Sockets/WebServer/WebServer.h > b/AppPkg/Applications/Sockets/WebServer/WebServer.h > > index 21b07b63df..16c30c8d6d 100644 > > --- a/AppPkg/Applications/Sockets/WebServer/WebServer.h > > +++ b/AppPkg/Applications/Sockets/WebServer/WebServer.h > > @@ -20,7 +20,6 @@ > > > > #include > > > > -#include > > #include > > #include > > #include > > diff --git a/AppPkg/Applications/Sockets/WebServer/Mtrr.c > b/AppPkg/Applications/Sockets/WebServer/Mtrr.c > > index 54356bde64..4b8482d4e2 100644 > > --- a/AppPkg/Applications/Sockets/WebServer/Mtrr.c > > +++ b/AppPkg/Applications/Sockets/WebServer/Mtrr.c > > @@ -15,6 +15,7 @@ > > > > #include > > #include > > +#include > > > > #define VARIABLE_MTRR_VALID 0x800 > > > > -- > > 2.11.0 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel