From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 32A8321962301 for ; Tue, 12 Feb 2019 07:22:36 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2019 07:22:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,362,1544515200"; d="scan'208";a="115601259" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 12 Feb 2019 07:22:35 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 12 Feb 2019 07:22:35 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.115]) by fmsmsx121.amr.corp.intel.com ([169.254.6.186]) with mapi id 14.03.0415.000; Tue, 12 Feb 2019 07:22:35 -0800 From: "Carsey, Jaben" To: Laszlo Ersek CC: "edk2-devel@lists.01.org" Thread-Topic: 3rd Party Python Packages Thread-Index: AdTC5r1DPD5ojKPDTCiR6lBlMVaO5g== Date: Tue, 12 Feb 2019 15:22:34 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGI1YzE2YjQtNGE4Yy00NWI3LWEzYTItYjEzOGU0NWM5MjFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiczRRbjROT2JkaXlSQ1YwTmEzTytnZzc3K3ZXMWkwcXdWWmJrbkgrdlwvb251aFFiOWtwbVNQKzhNSVljbllidGMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: 3rd Party Python Packages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 15:22:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Note: deviating from "RE: [edk2] [Patch 0/3] BaseTools: Implement splitquot= ed function" Laszlo, Since I am working on some research related to this, I have a few follow up= questions. If there is significant performance improvement, how would you feel about r= equiring a 3rd party package to be installed (via pip I think)? Would you feel more comfortable if BaseTools were able to run either with i= t or without (with performance differences)? Basically there are potential performance improvements, but use of 3rd part= y python packages is instrumental for many of them. =20 -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, February 12, 2019 6:02 AM > To: Gao, Liming ; Feng, Bob C > ; Bi, Dandan > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function >=20 > On 02/12/19 14:33, Gao, Liming wrote: > > Laszlo: > > To install python3-distutils should resolve this issue. I expect BaseT= ools > build functionality doesn't depend on the third party python lib. >=20 > I completely agree with your expectation, regarding *3rd party* python > packages. We shouldn't expect developers to install packages from > repositories that fall outside of their normal distro repos. >=20 > However, my understanding was that python3-distutils should be available > as a normal (not 3rd party) component on Ubuntu 18. I think we can > expect developers to install additional packages if those packages are > readily available in their normal (distro-provided) repos. >=20 > > So, I suggest to check whether python3-distutils is the native python > library. If it is native python library, why Ubuntu18 doesn't include it.= I will > work with Dandan to collect more information. >=20 > Right, that's exactly what I'm asking for. Thank you very much! > Laszlo >=20 > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:lersek@redhat.com] > >> Sent: Tuesday, February 12, 2019 8:24 PM > >> To: Feng, Bob C ; Bi, Dandan > > >> Cc: edk2-devel@lists.01.org; Gao, Liming > >> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted > function > >> > >> On 02/04/19 20:12, Laszlo Ersek wrote: > >>> On 02/03/19 06:55, Feng, Bob C wrote: > >>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1509 > >>>> On some Linux environment, there may be no distutils.util > >>>> library for python3 that will cause build tool crash. > >>>> This patch implement distutils.util.split_quoted > >>>> in BaseTools so that the Basetools will be independent with > >>>> distutils.util library. > >>>> > >>>> Feng, Bob C (3): > >>>> BaseTools: Implement splitquoted function in Build tool > >>>> BaseTools: Implement splitquoted function in UPT > >>>> BaseTools: unit test for splitquoted function > >>>> > >>>> BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 > ++++++++++++++++++++++++++++++++++++++++++++++---- > >>>> BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 > ++++++++++++++++++++++++++++++++++++++++++++--- > >>>> BaseTools/Tests/TestStringSplit.py | 38 > ++++++++++++++++++++++++++++++++++++++ > >>>> 3 files changed, 128 insertions(+), 7 deletions(-) > >>>> create mode 100644 BaseTools/Tests/TestStringSplit.py > >>>> > >>> > >>> Is this really necessary? BZ#1509 references Ubuntu18; however it loo= ks > >>> like the issue can be resolved by a simple package installation on > >>> Ubuntu 18: > >>> > >>> https://superuser.com/questions/1319047/cant-install-virtual- > interpreter-in-pycharm-in-linux > >>> > >>> """ > >>> sudo apt-get install python3-distutils > >>> """ > >>> > >>> I'm not a Ubuntu user myself; so all I can do here (without installin= g a > >>> Ubuntu18 VM) is check the Ubuntu package directory: > >>> > >>> https://packages.ubuntu.com/search?keywords=3Dpython3- > distutils&searchon=3Dnames&suite=3Dall§ion=3Dall > >>> > >>> python3-distutils appears available for both "bionic (18.04LTS)" and > >>> "cosmic (18.10)". > >>> > >>> Dandan, if you install python3-distutils, does that solve the issue f= or > you? > >> > >> I'd still like to get an answer to my question, before the series is p= ushed. > >> > >> Thanks, > >> Laszlo >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel