[PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Rebecca Cran]

The current servers listed appear to be unusable. I suspect most
people will get correct DNS servers via DHCP, but the defaults
should work for anyone.

Change the entries to be Google's public DNS servers.
Also, change the domain name to be example.com, to be more applicable
to consumers outside Intel.
---
 StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
index 3ac16ac230..724e6297b2 100644
--- a/StdLib/Efi/StdLib/etc/resolv.conf
+++ b/StdLib/Efi/StdLib/etc/resolv.conf
@@ -1,13 +1,13 @@
 #
 #   Domain name
 #
-domain          intel.com
+domain          example.com
 
 ;
 ;   Name Servers
 ;
-nameserver      206.63.63.61
-nameserver      216.251.100.1
+nameserver      8.8.8.8
+nameserver      8.8.4.4
 
 ; nameserver      10.248.2.1
 ; nameserver      10.22.224.204
-- 
2.20.1

Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Laszlo Ersek]

On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote:
> The current servers listed appear to be unusable. I suspect most
> people will get correct DNS servers via DHCP, but the defaults
> should work for anyone.
> 
> Change the entries to be Google's public DNS servers.
> Also, change the domain name to be example.com, to be more applicable
> to consumers outside Intel.
> ---
>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
> index 3ac16ac230..724e6297b2 100644
> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> @@ -1,13 +1,13 @@
>  #
>  #   Domain name
>  #
> -domain          intel.com
> +domain          example.com
>  
>  ;
>  ;   Name Servers
>  ;
> -nameserver      206.63.63.61
> -nameserver      216.251.100.1
> +nameserver      8.8.8.8
> +nameserver      8.8.4.4
>  
>  ; nameserver      10.248.2.1
>  ; nameserver      10.22.224.204
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

I'm quite undecided, but I vaguely feel that this should be pushed only
after we tag "edk2-stable201903". The domain name change doesn't look
like a pure bugfix, especially for Intel associates. Opinions?

Thanks,
Laszlo

Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Carsey, Jaben]

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, February 25, 2019 11:41 AM
> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Daryl McDaniel <edk2-
> lists@mc2research.org>
> Subject: Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's public
> DNS servers
> Importance: High
> 
> On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote:
> > The current servers listed appear to be unusable. I suspect most
> > people will get correct DNS servers via DHCP, but the defaults
> > should work for anyone.
> >
> > Change the entries to be Google's public DNS servers.
> > Also, change the domain name to be example.com, to be more applicable
> > to consumers outside Intel.
> > ---
> >  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/StdLib/Efi/StdLib/etc/resolv.conf
> b/StdLib/Efi/StdLib/etc/resolv.conf
> > index 3ac16ac230..724e6297b2 100644
> > --- a/StdLib/Efi/StdLib/etc/resolv.conf
> > +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> > @@ -1,13 +1,13 @@
> >  #
> >  #   Domain name
> >  #
> > -domain          intel.com
> > +domain          example.com
> >
> >  ;
> >  ;   Name Servers
> >  ;
> > -nameserver      206.63.63.61
> > -nameserver      216.251.100.1
> > +nameserver      8.8.8.8
> > +nameserver      8.8.4.4
> >
> >  ; nameserver      10.248.2.1
> >  ; nameserver      10.22.224.204
> >
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> I'm quite undecided, but I vaguely feel that this should be pushed only
> after we tag "edk2-stable201903". The domain name change doesn't look
> like a pure bugfix, especially for Intel associates. Opinions?

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

I have no strong opinion on timing.

> 
> Thanks,
> Laszlo

Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Laszlo Ersek]

On 02/25/19 22:16, Carsey, Jaben wrote:
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Monday, February 25, 2019 11:41 AM
>> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Daryl McDaniel <edk2-
>> lists@mc2research.org>
>> Subject: Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's public
>> DNS servers
>> Importance: High
>>
>> On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote:
>>> The current servers listed appear to be unusable. I suspect most
>>> people will get correct DNS servers via DHCP, but the defaults
>>> should work for anyone.
>>>
>>> Change the entries to be Google's public DNS servers.
>>> Also, change the domain name to be example.com, to be more applicable
>>> to consumers outside Intel.
>>> ---
>>>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf
>> b/StdLib/Efi/StdLib/etc/resolv.conf
>>> index 3ac16ac230..724e6297b2 100644
>>> --- a/StdLib/Efi/StdLib/etc/resolv.conf
>>> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
>>> @@ -1,13 +1,13 @@
>>>  #
>>>  #   Domain name
>>>  #
>>> -domain          intel.com
>>> +domain          example.com
>>>
>>>  ;
>>>  ;   Name Servers
>>>  ;
>>> -nameserver      206.63.63.61
>>> -nameserver      216.251.100.1
>>> +nameserver      8.8.8.8
>>> +nameserver      8.8.4.4
>>>
>>>  ; nameserver      10.248.2.1
>>>  ; nameserver      10.22.224.204
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>> I'm quite undecided, but I vaguely feel that this should be pushed only
>> after we tag "edk2-stable201903". The domain name change doesn't look
>> like a pure bugfix, especially for Intel associates. Opinions?
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
> I have no strong opinion on timing.

OK, let's delay this one. I'll keep it tagged.

Thanks,
Laszlo

Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Laszlo Ersek]

On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote:
> The current servers listed appear to be unusable. I suspect most
> people will get correct DNS servers via DHCP, but the defaults
> should work for anyone.
> 
> Change the entries to be Google's public DNS servers.
> Also, change the domain name to be example.com, to be more applicable
> to consumers outside Intel.
> ---
>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
> index 3ac16ac230..724e6297b2 100644
> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> @@ -1,13 +1,13 @@
>  #
>  #   Domain name
>  #
> -domain          intel.com
> +domain          example.com
>  
>  ;
>  ;   Name Servers
>  ;
> -nameserver      206.63.63.61
> -nameserver      216.251.100.1
> +nameserver      8.8.8.8
> +nameserver      8.8.4.4
>  
>  ; nameserver      10.248.2.1
>  ; nameserver      10.22.224.204
> 

Sorry for missing this earlier, but the patch misses the
Contributed-under and Signed-off-by lines, from the end of the commit
message.

Please repost like that, and then please also include the Reviewed-by
tags from Jaben and myself.

Thanks,
Laszlo

Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

[Rebecca Cran]

On 2/26/19 5:31 AM, Laszlo Ersek wrote:

>
> Sorry for missing this earlier, but the patch misses the
> Contributed-under and Signed-off-by lines, from the end of the commit
> message.
>
> Please repost like that, and then please also include the Reviewed-by
> tags from Jaben and myself.


I'm just catching up on edk2 work again. I've just sent out a new patch.


-- 
Rebecca Cran