From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking
Date: Thu, 28 Feb 2019 15:49:32 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CBCB900B1@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20190228131909.2612-1-bob.c.feng@intel.com>
Is this something that should also get added to edksetup? Force users to get the error without running this test.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Thursday, February 28, 2019 5:19 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package
> checking
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1509
>
> Add python3-distutils Ubuntu package checking.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Tests/RunTests.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py
> index 0dd65632d0..356c1d600c 100644
> --- a/BaseTools/Tests/RunTests.py
> +++ b/BaseTools/Tests/RunTests.py
> @@ -17,10 +17,17 @@
> #
> import os
> import sys
> import unittest
>
> +try:
> + import distutils.util
> +except ModuleNotFoundError:
> + sys.exit('''
> +Python reported: "No module named 'distutils.uitl'"
> +''')
> +
> import TestTools
>
> def GetCTestSuite():
> import CToolsTests
> return CToolsTests.TheTestSuite()
> --
> 2.20.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2019-02-28 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:19 [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking Feng, Bob C
2019-02-28 13:29 ` Feng, Bob C
2019-02-28 13:49 ` Philippe Mathieu-Daudé
2019-02-28 15:49 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CBCB900B1@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox