From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 40717202E53C3 for ; Fri, 1 Mar 2019 08:00:54 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2019 08:00:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,428,1544515200"; d="scan'208";a="130435016" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 01 Mar 2019 08:00:54 -0800 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Mar 2019 08:00:53 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.115]) by FMSMSX161.amr.corp.intel.com ([169.254.12.114]) with mapi id 14.03.0415.000; Fri, 1 Mar 2019 08:00:53 -0800 From: "Carsey, Jaben" To: "Fan, ZhijuX" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed Thread-Index: AdTP2ZBeSFBwSb0KS2a2UoNayCuamQAbmAxA Date: Fri, 1 Mar 2019 16:00:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk1ZjE3NTQtNGI1Mi00NGE5LWFjOGQtODA0NmU3MmIyZjJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9cL1VjcWN4UFBoZlE0WjZQaytkQng4MTR1QjJXcU9Yc0lnV1hsMW5WaUNsVlZxTkZtWFVpMk5ySGRkQU41T3VKIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 16:00:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Fan, ZhijuX > Sent: Thursday, February 28, 2019 6:52 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate > doc failed >=20 > The reason for this problem is that the file was opened incorrectly. >=20 > Cc: Bob Feng > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhiju.Fan > --- > .../plugins/EdkPlugins/edk2/model/doxygengen.py | 7 += +++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git > a/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/edk2/mode > l/doxygengen.py > b/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/edk2/mod > el/doxygengen.py > index e31df262bc..73349e2f48 100644 > --- > a/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/edk2/mode > l/doxygengen.py > +++ > b/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/edk2/mod > el/doxygengen.py > @@ -376,9 +376,10 @@ class PackageDocumentAction(DoxygenAction): > return >=20 > try: > - f =3D open(path, 'r') > - lines =3D f.readlines() > - f.close() > + with open(path, 'r') as f: > + lines =3D f.readlines() > + except UnicodeDecodeError: > + return > except IOError: > ErrorMsg('Fail to open file %s' % path) > return > -- > 2.14.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel