From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1413F201B0457 for ; Tue, 5 Mar 2019 07:21:21 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 07:21:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,444,1544515200"; d="scan'208";a="324397072" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 05 Mar 2019 07:21:21 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 07:21:21 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.115]) by FMSMSX126.amr.corp.intel.com ([169.254.1.212]) with mapi id 14.03.0415.000; Tue, 5 Mar 2019 07:21:21 -0800 From: "Carsey, Jaben" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg: Correct a parameter's name Thread-Index: AQHU0vgEwKmt5nCMPkS6ju14C9/eRqX9KDZA Date: Tue, 5 Mar 2019 15:21:19 +0000 Message-ID: References: <20190305020553.5908-1-shenglei.zhang@intel.com> In-Reply-To: <20190305020553.5908-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWZhNzllYzgtNDhkZC00NjhhLTkyNjAtNmJmMGM0NDczNTE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU3A5d3A0QWxhM04zYjFudU1YXC9Xd0JQckdjN0hGRzd4dWxCZXVEUndcL01EMFNUYTh0RlViQkxOT21hVTdHRlwvVCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Correct a parameter's name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 15:21:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, March 04, 2019 6:06 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH] ShellPkg: Correct a parameter's name > Importance: High >=20 > The parameter FilePath of ShellOpenFileByName defined in > ShellLib.h is incorrect. It should be FileName. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1221 >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Include/Library/ShellLib.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Include/Library/ShellLib.h > b/ShellPkg/Include/Library/ShellLib.h > index 2ecc5ee006..78bdcc8c53 100644 > --- a/ShellPkg/Include/Library/ShellLib.h > +++ b/ShellPkg/Include/Library/ShellLib.h > @@ -161,7 +161,7 @@ ShellOpenFileByDevicePath( > otherwise, the Filehandle is NULL. Attributes is valid only for > EFI_FILE_MODE_CREATE. >=20 > - @param[in] FilePath The pointer to file name. > + @param[in] FileName The pointer to file name. > @param[out] FileHandle The pointer to the file handle. > @param[in] OpenMode The mode to open the file with. > @param[in] Attributes The file's file attributes. > @@ -186,7 +186,7 @@ ShellOpenFileByDevicePath( > EFI_STATUS > EFIAPI > ShellOpenFileByName( > - IN CONST CHAR16 *FilePath, > + IN CONST CHAR16 *FileName, > OUT SHELL_FILE_HANDLE *FileHandle, > IN UINT64 OpenMode, > IN UINT64 Attributes > -- > 2.18.0.windows.1