Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

["Carsey, Jaben" <jaben.carsey@intel.com>]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Tuesday, March 05, 2019 11:05 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray <ray.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note
> in uni
> Importance: High
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146
> 
> Add DSDT and SSDT description in the help information. Depend
> on the implement of UefiShellAcpiViewCommandLib, the "acpiview"
> command support to show all present type in the system not only
> support the listed type in the help information. So change the
> help information of this command.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni   | 8
> +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> index 0762eeba53..f2a2400b91 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.uni
> @@ -74,10 +74,15 @@
>  "  1. The AcpiTable parameter can match any installed table type.\r\n"
>  "     Tables without specific handling will be displayed as a raw hex dump
> (or\r\n"
>  "     dumped to a file if -d is used).\r\n"
> -"  2. Formatted display and checking is provided for these signature
> types:\r\n"
> +"  2. -s option supports to display the specified AcpiTable type that is
> present\r\n"
> +"     in the system. For normal type AcpiTable, it would display the data of
> the\r\n"
> +"     AcpiTable and AcpiTable header. The following type may contain header
> type\r\n"
> +"     other than AcpiTable header. The acual header can refer to the ACPI
> spec 6.2\r\n"
> +"     Extra A. Particual types:\r\n"
>  "       APIC  - Multiple APIC Description Table (MADT)\r\n"
>  "       BGRT  - Boot Graphics Resource Table\r\n"
>  "       DBG2  - Debug Port Table 2\r\n"
> +"       DSDT  - Differentiated System Description Table\r\n"
>  "       FACP  - Fixed ACPI Description Table (FADT)\r\n"
>  "       GTDT  - Generic Timer Description Table\r\n"
>  "       IORT  - IO Remapping Table\r\n"
> @@ -87,6 +92,7 @@
>  "       SLIT  - System Locality Information Table\r\n"
>  "       SPCR  - Serial Port Console Redirection Table\r\n"
>  "       SRAT  - System Resource Affinity Table\r\n"
> +"       SSDT  - Secondary SystemDescription Table\r\n"
>  "       XSDT  - Extended System Description Table\r\n"
>  " \r\n"
>  ".SH STANDARDS\r\n"
> --
> 2.16.2.windows.1