From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed.
Date: Thu, 14 Mar 2019 14:57:33 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CBCBAB553@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20190314144732.20064-1-bob.c.feng@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Thursday, March 14, 2019 7:48 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall
> failed.
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1622
> There is duplicated $(PYTHON_COMMAND) in the
> command of cleanall
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/C/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/C/Makefile b/BaseTools/Source/C/Makefile
> index 08f0081212..ca71bd1178 100644
> --- a/BaseTools/Source/C/Makefile
> +++ b/BaseTools/Source/C/Makefile
> @@ -65,10 +65,10 @@ clean:
> @if defined PYTHON_COMMAND $(PYTHON_COMMAND)
> Makefiles\NmakeSubdirs.py clean $(LIBRARIES) $(APPLICATIONS)
> @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe
> Makefiles\NmakeSubdirs.py clean $(LIBRARIES) $(APPLICATIONS)
>
> .PHONY: cleanall
> cleanall:
> - @if defined PYTHON_COMMAND $(PYTHON_COMMAND)
> $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES)
> $(APPLICATIONS)
> - @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe
> $(PYTHON_COMMAND) Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES)
> $(APPLICATIONS)
> + @if defined PYTHON_COMMAND $(PYTHON_COMMAND)
> Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
> + @if not defined PYTHON_COMMAND $(PYTHON_HOME)\python.exe
> Makefiles\NmakeSubdirs.py cleanall $(LIBRARIES) $(APPLICATIONS)
>
> !INCLUDE Makefiles\ms.rule
>
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2019-03-14 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 14:47 [Patch] BaseTools: Fixed the issue of BaseTools Make cleanall failed Feng, Bob C
2019-03-14 14:57 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CBCBAB553@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox