From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 856AD211EB82A for ; Thu, 28 Mar 2019 19:54:19 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 19:54:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,283,1549958400"; d="scan'208";a="138216443" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 28 Mar 2019 19:54:18 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 19:54:18 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.108]) by FMSMSX119.amr.corp.intel.com ([169.254.14.119]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 19:54:17 -0700 From: "Carsey, Jaben" To: "Ni, Ray" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids Thread-Index: AQHU5dCSy5vyr8zuC0mf1kpqL++oQKYiTSSA//+cm+A= Date: Fri, 29 Mar 2019 02:54:17 +0000 Message-ID: References: <20190329014126.20208-1-shenglei.zhang@intel.com> <20190329014126.20208-4-shenglei.zhang@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C0A27FA@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C0A27FA@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTBmNGZmNzgtN2IzZS00ODNmLTgyMjctYmU0YTdmZjllZGMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid2dxMm9lXC9tN3A3UWgrdEhENkE3V0QyRmtiaE0yWk9iWXl6SkhFc3F0UXVGR2lmNkVTUHJhNGkyTTBTNUs4SGEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 02:54:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:50 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some > unused Guids > Importance: High >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, March 29, 2019 9:41 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben ; Ni, Ray > > Subject: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused > > Guids > > > > ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h > > will be deleted. So remove the Guids defined in these Protocols. And > > also remove strings in uni file. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1560 > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 ----------------- > > .../UefiHandleParsingLib.inf | 17 ----------------- > > .../UefiHandleParsingLib.uni | 17 ----------------- > > 3 files changed, 51 deletions(-) > > > > diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > index 2d94a52108..a106c0906c 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > @@ -2321,23 +2321,6 @@ STATIC CONST GUID_INFO_BLOCK > mGuidStringList[] > > =3D { > > {STRING_TOKEN(STR_FVB2), > > &gEfiFirmwareVolumeBlock2ProtocolGuid, NULL}, > > {STRING_TOKEN(STR_CPUIO2), &gEfiCpuIo2ProtocolGuid, > > NULL}, > > {STRING_TOKEN(STR_LEGACY_R2), > &gEfiLegacyRegion2ProtocolGuid, > > NULL}, > > - {STRING_TOKEN(STR_SAL_MIP), &gEfiSalMcaInitPmiProtocol= Guid, > > NULL}, > > - {STRING_TOKEN(STR_ES_BS), > > &gEfiExtendedSalBootServiceProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_BIO), > > &gEfiExtendedSalBaseIoServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_STALL), > > &gEfiExtendedSalStallServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_RTC), > > &gEfiExtendedSalRtcServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_VS), > > &gEfiExtendedSalVariableServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MTC), > > &gEfiExtendedSalMtcServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_RESET), > > &gEfiExtendedSalResetServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_SC), > > &gEfiExtendedSalStatusCodeServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_FBS), > > &gEfiExtendedSalFvBlockServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MP), > > &gEfiExtendedSalMpServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_PAL), > > &gEfiExtendedSalPalServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_BASE), > > &gEfiExtendedSalBaseServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MCA), > > &gEfiExtendedSalMcaServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_PCI), > > &gEfiExtendedSalPciServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_CACHE), > > &gEfiExtendedSalCacheServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MCA_LOG), > > &gEfiExtendedSalMcaLogServicesProtocolGuid, NULL}, > > {STRING_TOKEN(STR_S2ARCH), &gEfiSecurity2ArchProtocol= Guid, > > NULL}, > > {STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGu= id, > > NULL}, > > {STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid, > > NULL}, > > diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > index a795fb92de..edab57f892 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > @@ -234,23 +234,6 @@ > > gEfiFirmwareVolumeBlock2ProtocolGuid ## UNDEFINED > > gEfiCpuIo2ProtocolGuid ## UNDEFINED > > gEfiLegacyRegion2ProtocolGuid ## UNDEFINED > > - gEfiSalMcaInitPmiProtocolGuid ## UNDEFINED > > - gEfiExtendedSalBootServiceProtocolGuid ## UNDEFINED > > - gEfiExtendedSalBaseIoServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalStallServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalRtcServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMtcServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalResetServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalStatusCodeServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalFvBlockServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMpServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalPalServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalBaseServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMcaServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalPciServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalCacheServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMcaLogServicesProtocolGuid ## UNDEFINED > > gEfiSecurity2ArchProtocolGuid ## UNDEFINED > > gEfiSmmEndOfDxeProtocolGuid ## UNDEFINED > > gEfiIsaHcProtocolGuid ## UNDEFINED > > diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > index 15f3912045..3238441b1e 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > @@ -274,23 +274,6 @@ > > #string STR_FVB2 #language en-US "FirmwareVolumeBlock= 2" > > #string STR_CPUIO2 #language en-US "CpuIo2" > > #string STR_LEGACY_R2 #language en-US "LegacyRegion2" > > -#string STR_SAL_MIP #language en-US "SalMcaInitPmi" > > -#string STR_ES_BS #language en-US "ExtendedSalBootServ= ice" > > -#string STR_ES_BIO #language en-US "ExtendedSalBaseIoSe= rvices" > > -#string STR_ES_STALL #language en-US "ExtendedSalStallSer= vices" > > -#string STR_ES_RTC #language en-US "ExtendedSalRtcServi= ces" > > -#string STR_ES_VS #language en-US > "ExtendedSalVariableServices" > > -#string STR_ES_MTC #language en-US "ExtendedSalMtcServi= ces" > > -#string STR_ES_RESET #language en-US "ExtendedSalResetSer= vices" > > -#string STR_ES_SC #language en-US > "ExtendedSalStatusCodeServices" > > -#string STR_ES_FBS #language en-US > "ExtendedSalFvBlockServices" > > -#string STR_ES_MP #language en-US "ExtendedSalMpServic= es" > > -#string STR_ES_PAL #language en-US "ExtendedSalPalServi= ces" > > -#string STR_ES_BASE #language en-US "ExtendedSalBaseServ= ices" > > -#string STR_ES_MCA #language en-US "ExtendedSalMcaServi= ces" > > -#string STR_ES_PCI #language en-US "ExtendedSalPciServi= ces" > > -#string STR_ES_CACHE #language en-US > "ExtendedSalCacheServices" > > -#string STR_ES_MCA_LOG #language en-US > > "ExtendedSalMcaLogServices" > > #string STR_S2ARCH #language en-US "Security2Arch" > > #string STR_EODXE #language en-US "SmmEndOfDxe" > > #string STR_ISAHC #language en-US "IsaHc" > > -- > > 2.18.0.windows.1