From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5311B211EB82A for ; Thu, 28 Mar 2019 19:54:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 19:54:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,283,1549958400"; d="scan'208";a="126829487" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 28 Mar 2019 19:54:23 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 19:54:23 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.108]) by FMSMSX102.amr.corp.intel.com ([169.254.10.60]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 19:54:22 -0700 From: "Carsey, Jaben" To: "Ni, Ray" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib Thread-Index: AQHU5dCSfWj//7dOmUWxh/XF2LcJqqYiTSSA//+covA= Date: Fri, 29 Mar 2019 02:54:22 +0000 Message-ID: References: <20190329014126.20208-1-shenglei.zhang@intel.com> <20190329014126.20208-3-shenglei.zhang@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C0A27F5@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C0A27F5@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmM0ZDlhMzAtMjExOS00ODM2LTk0NzMtNTY3OTE2Njk5ZjQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTEJ1Y0pZamdRRUtmWnFnajY4YmlDdDh0Znl4V3M0Q2ZEdFhcLzlLalBhdWRGNml2R1BEenRzVnBDZUJcL2w0b2ZZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 02:54:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:50 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib > Importance: High >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, March 29, 2019 9:41 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben ; Ni, Ray > > Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib > > > > With Itanium architecture unsupported, gEfiSalSystemTableGuid and > > gEfiMpsTableGuid will be no longer used. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1560 > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 10 ---------- > > .../UefiShellDebug1CommandsLib.inf | 2 -- > > 2 files changed, 12 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > > index a4c18c9b68..023806742d 100644 > > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > > @@ -17,9 +17,7 @@ > > #include "UefiShellDebug1CommandsLib.h" > > #include #include > > -#include #include -#include > > > > > > /** > > Make a printable character. > > @@ -186,10 +184,6 @@ ShellCommandRunDmem ( > > AcpiTableAddress =3D (UINT64)(UINTN)gST- > > >ConfigurationTable[TableWalker].VendorTable; > > continue; > > } > > - if (CompareGuid(&gST- > >ConfigurationTable[TableWalker].VendorGuid, > > &gEfiSalSystemTableGuid)) { > > - SalTableAddress =3D (UINT64)(UINTN)gST- > > >ConfigurationTable[TableWalker].VendorTable; > > - continue; > > - } > > if > > (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid, > > &gEfiSmbiosTableGuid)) { > > SmbiosTableAddress =3D (UINT64)(UINTN)gST- > > >ConfigurationTable[TableWalker].VendorTable; > > continue; > > @@ -198,10 +192,6 @@ ShellCommandRunDmem ( > > SmbiosTableAddress =3D (UINT64) (UINTN) gST- > > >ConfigurationTable[TableWalker].VendorTable; > > continue; > > } > > - if (CompareGuid(&gST- > >ConfigurationTable[TableWalker].VendorGuid, > > &gEfiMpsTableGuid)) { > > - MpsTableAddress =3D (UINT64)(UINTN)gST- > > >ConfigurationTable[TableWalker].VendorTable; > > - continue; > > - } > > } > > > > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN > > (STR_DMEM_SYSTEM_TABLE), gShellDebug1HiiHandle, diff --git > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsL > > i > > b.inf > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsL > > i > > b.inf > > index ec1f87ae19..f2666b7ff9 100644 > > --- > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsL > > i > > b.inf > > +++ > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > d > > +++ sLib.inf > > @@ -130,8 +130,6 @@ > > gEfiGlobalVariableGuid ## SOMETIMES_CONSUMES ## GUID > > gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable > > gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable > > - gEfiMpsTableGuid ## SOMETIMES_CONSUMES ## SystemTable > > - gEfiSalSystemTableGuid ## SOMETIMES_CONSUMES ## SystemTable > > gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable > > gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable > > gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII > > -- > > 2.18.0.windows.1