From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jaben.carsey@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 07 May 2019 07:35:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2019 07:35:30 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 07 May 2019 07:35:30 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 7 May 2019 07:35:31 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.162]) by FMSMSX113.amr.corp.intel.com ([169.254.13.30]) with mapi id 14.03.0415.000; Tue, 7 May 2019 07:35:30 -0700 From: "Carsey, Jaben" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Ni, Ray" , "jwatt@jwatt.org" CC: "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option Thread-Topic: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option Thread-Index: AQHVBAwgBZMJ5pxvi0a+WqdyZp11UKZeleQAgAFMRoD//9mpsA== Date: Tue, 7 May 2019 14:35:30 +0000 Message-ID: References: <20190506130257.80722-1-jwatt@jwatt.org> <20190506130257.80722-2-jwatt@jwatt.org> <734D49CCEBEEF84792F5B80ED585239D5C12C3EF@SHSMSX104.ccr.corp.intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7D0C0D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7D0C0D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGM0OGI1OWQtZGFmMi00NWY5LWEyMmMtMmUzZTRiMjEzMjU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0NwSjE5WXgrUXEyWWtZUXJpQWRcL3NMbDBWTmtVQVVyZENRMWtWUGxXWG5uRDBiSUZSSVhTU3BTTGlQNmx5d00ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Return-Path: jaben.carsey@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, I can help submit errata for shell spec if needed. Per patch, I agree. This looks good. Reviewed-by: Jaben Carsey > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, May 07, 2019 2:52 AM > To: devel@edk2.groups.io; Ni, Ray ; jwatt@jwatt.org > Cc: Carsey, Jaben ; Bi, Dandan > > Subject: RE: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > Importance: High >=20 > This patch looks good for me. > Reviewed-by: Zhichao Gao >=20 > But when I view the command in UEFI SHELL 2.2 spec: > ... > bcfg driver|boot [-opt # [[filename]|["data"]] | [KeyData UnicodeChar>*]] > ... > -opt > Modify the optional data associated with a driver or boot option. Follow= ed > either by the filename of the file which contains the binary data to be > associated with the driver or boot option optional data, or else the quo= te- > delimited data that will be associated with the driver or boot option op= tional > data. > ... >=20 > This description lack the comment of '#' parameter and that may make the > consumer confused. Usually consumers would regard it as the same in othe= r > option, such as ' bcfg driver|boot [rm #]'. The '#' is clearly descripte= d as a > hexadecimal parameter: > rm > Remove an option. The # parameter lists the option number to remove in > hexadecimal. >=20 > So I think we should update the shell spec by the way. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ni, > > Ray > > Sent: Monday, May 6, 2019 10:02 PM > > To: jwatt@jwatt.org; devel@edk2.groups.io > > Cc: Carsey, Jaben ; Bi, Dandan > > > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: > > Fix '-opt' option > > > > Dandan, > > Can you please help to review? > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: jwatt@jwatt.org [mailto:jwatt@jwatt.org] > > > Sent: Monday, May 6, 2019 9:03 PM > > > To: devel@edk2.groups.io > > > Cc: Carsey, Jaben ; Ni, Ray > > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' > > > option > > > > > > From: Jonathan Watt > > > > > > For all other bcfg commands the "#" (option number) argument(s) are > > > treated as hexedecimal values regardless of whether or not they are > > > prefixed by "0x". This change fixes '-opt' to handle its "#" > > > (option number) argument consistently with the other commands. > > > > > > Making this change removes a potential footgun whereby a user that h= as > > > been using a number without a "0x" prefix with other bcfg commands > > > finds that, on using that exact same number with '-opt', it has this > > > time unexpectedly been interpreted as a decimal number and they have > > > modified > > > (corrupted) an unrelated load option. For example, a user may have > > > been specifying "10" to other commands to have them act on the 16th > > > option (because simply "10", without any prefix, is how 'bcfg boot > > > dump' displayed the option number for the 16th option). Unfortunatel= y > > > for them, if they also use '-opt' with "10" it would unexpectedly an= d > > > inconsistently act on the 10th option. > > > > > > CC: Jaben Carsey > > > CC: Ray Ni > > > Signed-off-by: Jonathan Watt > > > --- > > > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > | > > > 2 > > > +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > index d033c7c1dc59..e8b48b4990dd 100644 > > > --- > > > > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > +++ > > > > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > @@ -1019,7 +1019,7 @@ BcfgAddOpt( > > > // > > > // Get the index of the variable we are changing. > > > // > > > - Status =3D ShellConvertStringToUint64(Walker, &Intermediate, FALS= E, > > > TRUE); > > > + Status =3D ShellConvertStringToUint64(Walker, &Intermediate, TRUE= , > > > + TRUE); > > > if (EFI_ERROR(Status) || (((UINT16)Intermediate) !=3D Intermediat= e) > > > || StrStr(Walker, L" ") =3D=3D NULL || ((UINT16)Intermediate) > > > > ((UINT16)OrderCount)) { > > > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV), > > > gShellBcfgHiiHandle, L"bcfg", L"Option Index"); > > > ShellStatus =3D SHELL_INVALID_PARAMETER; > > > -- > > > 2.21.0 > > > > > >=20