From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jaben.carsey@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 20 May 2019 09:35:10 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 09:35:09 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 20 May 2019 09:35:09 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 09:35:08 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.236]) by FMSMSX151.amr.corp.intel.com ([169.254.7.50]) with mapi id 14.03.0415.000; Mon, 20 May 2019 09:35:08 -0700 From: "Carsey, Jaben" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Gao, Zhichao" , "Ni, Ray" Subject: Re: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency Thread-Topic: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency Thread-Index: AQHVDw0/MkeU90KMNUSDgL9QAASD1qZ0EY2A Date: Mon, 20 May 2019 16:35:08 +0000 Message-ID: References: <20190520130920.9464-1-liming.gao@intel.com> <20190520130920.9464-2-liming.gao@intel.com> In-Reply-To: <20190520130920.9464-2-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTYzZDliOGEtMWM1Ni00ZDAxLWI4OTQtN2U5MDM4NjA0MzEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVkdxRTB5VUJGXC80ZjZDT0owUmpzRnREcWt1U3Z6and2c3FiU3N6Y0pJeThzXC9Hem1paExhajI2S21EalJIQ2NQIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Return-Path: jaben.carsey@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Netlib class definition and instance are both moving? Are these modules using MdeModulePkg for a different lib or can we remove i= t? > -----Original Message----- > From: Gao, Liming > Sent: Monday, May 20, 2019 6:09 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; > Carsey, Jaben > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the > package dependency > Importance: High >=20 > NetLib will be moved from MdeModulePkg and NetworkPkg. > So, the module that consumes NetLib need to depend on NetworkPkg.dec. >=20 > Signed-off-by: Liming Gao > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Jaben Carsey > --- > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf |= 3 > ++- >=20 > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. > inf | 3 ++- > .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > | 3 ++- > .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf > | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > index 9d57e59c63..bc13c89a97 100644 > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides Shell 'tftp' standalone application. > # > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > # Copyright (c) 2015, ARM Ltd. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -31,6 +31,7 @@ [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > MemoryAllocationLib > diff --git > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > index f23445102a..b0c8e8f84b 100644 > --- > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > +++ > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides Shell 'tftp' dynamic command. > # > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > # Copyright (c) 2015, ARM Ltd. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -32,6 +32,7 @@ [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > MemoryAllocationLib > diff --git > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > index 8054dc6f51..1e6ce63e3e 100644 > --- > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > +++ > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides shell network1 functions > # > -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -29,6 +29,7 @@ [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > MemoryAllocationLib > diff --git > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > index a9ca31a310..9ffcf85248 100644 > --- > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > +++ > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides shell network2 functions > # > -# Copyright (c) 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -29,6 +29,7 @@ [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec >=20 > [LibraryClasses] > MemoryAllocationLib > -- > 2.13.0.windows.1