Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

["Carsey, Jaben" <jaben.carsey@intel.com>]

Pushed as sufficient RB's were received.

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Sunday, June 09, 2019 8:09 PM
> To: PierreGondois <pierre.gondois@arm.com>; devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> sami.mujawar@arm.com; Matteo.Carlini@arm.com; Stephanie.Hughes-
> Fitt@arm.com; nd@arm.com
> Subject: RE: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> Importance: High
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> I would collect the R-B and send to the maintainer to push.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: PierreGondois [mailto:pierre.gondois@arm.com]
> > Sent: Thursday, June 6, 2019 8:29 PM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Gao, Zhichao <zhichao.gao@intel.com>; sami.mujawar@arm.com;
> > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com;
> > pierre.gondois@arm.com; nd@arm.com
> > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > The ACPI 6.3 specification introduces support to describe the ARMv8.1
> virtual
> > EL2 timers. This patch updates the GTDT parser of acpiview to decode the
> EL2
> > virtual timer fields.
> >
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> >
> > The changes can be seen at:
> >
> https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd
> > ate_v1
> >
> > Notes:
> >     v1:
> >     - GTDT updates for ACPI 6.3 [Pierre]
> >
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
> > | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> > index
> >
> 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05
> > 7c32369a456267 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> > +++
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars
> > +++ er.c
> > @@ -5,7 +5,7 @@
> >    SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >    @par Reference(s):
> > -    - ACPI 6.2 Specification - Errata A, September 2017
> > +    - ACPI 6.3 Specification - January 2019
> >    **/
> >
> >  #include <IndustryStandard/Acpi.h>
> > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
> >    {L"Platform Timer Count", 4, 88, L"%d", NULL,
> >     (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
> >    {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
> > -   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
> > +   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},  {L"Virtual EL2 Timer
> > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},  {L"Virtual EL2 Timer
> > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
> >  };
> >
> >  /**
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'