From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jaben.carsey@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Mon, 10 Jun 2019 12:00:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 12:00:24 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 10 Jun 2019 12:00:24 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Jun 2019 12:00:23 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.74]) by fmsmsx121.amr.corp.intel.com ([169.254.6.50]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 12:00:23 -0700 From: "Carsey, Jaben" To: "Gao, Zhichao" , PierreGondois , "devel@edk2.groups.io" CC: "Ni, Ray" , "sami.mujawar@arm.com" , "Matteo.Carlini@arm.com" , "Stephanie.Hughes-Fitt@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 Thread-Topic: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 Thread-Index: AQHVHGNn/Mq1ld7EDUGQICzXVduRKaaUsEwAgACUNmA= Date: Mon, 10 Jun 2019 19:00:22 +0000 Message-ID: References: <20190606122836.8888-1-pierre.gondois@arm.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7E50F2@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7E50F2@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JiOTUyZGEtODY3YS00MjFiLTg0OTAtYWQ4Yjc0ZjQ1YjA1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicTJvd3hpT0VqbXA0emRjTjNXN0FLZ3NQWVNBSG9iMllmd2dnbVBNTTBrSW8zUTNPSEd0dUlwU1RNTWo4Q1N6WiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Return-Path: jaben.carsey@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as sufficient RB's were received. > -----Original Message----- > From: Gao, Zhichao > Sent: Sunday, June 09, 2019 8:09 PM > To: PierreGondois ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > sami.mujawar@arm.com; Matteo.Carlini@arm.com; Stephanie.Hughes- > Fitt@arm.com; nd@arm.com > Subject: RE: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 > Importance: High >=20 > Reviewed-by: Zhichao Gao >=20 > I would collect the R-B and send to the maintainer to push. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: PierreGondois [mailto:pierre.gondois@arm.com] > > Sent: Thursday, June 6, 2019 8:29 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray ; > > Gao, Zhichao ; sami.mujawar@arm.com; > > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; > > pierre.gondois@arm.com; nd@arm.com > > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 > > > > From: Pierre Gondois > > > > The ACPI 6.3 specification introduces support to describe the ARMv8.1 > virtual > > EL2 timers. This patch updates the GTDT parser of acpiview to decode th= e > EL2 > > virtual timer fields. > > > > Signed-off-by: Pierre Gondois > > --- > > > > The changes can be seen at: > > > https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd > > ate_v1 > > > > Notes: > > v1: > > - GTDT updates for ACPI 6.3 [Pierre] > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > > | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > > .c > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > > .c > > index > > > 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05 > > 7c32369a456267 100644 > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > > .c > > +++ > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > > +++ er.c > > @@ -5,7 +5,7 @@ > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @par Reference(s): > > - - ACPI 6.2 Specification - Errata A, September 2017 > > + - ACPI 6.3 Specification - January 2019 > > **/ > > > > #include > > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] =3D { > > {L"Platform Timer Count", 4, 88, L"%d", NULL, > > (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, > > {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, > > - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} > > + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Time= r > > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer > > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} > > }; > > > > /** > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'