From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jaben.carsey@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Mon, 24 Jun 2019 07:54:15 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 07:54:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,412,1557212400"; 
   d="scan'208";a="187945133"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by fmsmga002.fm.intel.com with ESMTP; 24 Jun 2019 07:54:14 -0700
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 24 Jun 2019 07:54:14 -0700
Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.55]) by
 FMSMSX155.amr.corp.intel.com ([169.254.5.98]) with mapi id 14.03.0439.000;
 Mon, 24 Jun 2019 07:54:14 -0700
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Feng, Bob C"
	<bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two
Thread-Topic: [edk2-devel] [Patch 0/2] BaseTools: Separate current
 CreateAsBuiltInf function into two
Thread-Index: AQHVKi9OFdVQk5V5hEiUlRj9Cy5JeKaq5Oeg
Date: Mon, 24 Jun 2019 14:54:13 +0000
Message-ID: <CB6E33457884FA40993F35157061515CBCCBD985@FMSMSX103.amr.corp.intel.com>
References: <20190624015048.16724-1-bob.c.feng@intel.com>
In-Reply-To: <20190624015048.16724-1-bob.c.feng@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjFjNDU0ZjYtYWNkNC00Y2FhLTg2MWYtNDhiOGExZjk1MDBmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidUlXZkE2NStaZUZrYWVRQmFNZVUwY0llZnRvRFwvQ1wvb3l6Y3QxQStmeEZ4TjhFK21tMVpyZkRlVlNDY3doVE9YIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.1.200.106]
MIME-Version: 1.0
Return-Path: jaben.carsey@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Much clearer code to see what's actually happening.


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Bob Feng
> Sent: Sunday, June 23, 2019 6:51 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch 0/2] BaseTools: Separate current
> CreateAsBuiltInf function into two
>=20
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D1932
>=20
> In current implementation, there are 2 functions in CreateAsBuiltInf,
> one is create asbuildinf, the other is update build cache.
> They should be separated.
>=20
> Feng, Bob C (2):
>   BaseTools: refine CreateAsBuiltInf function
>   BaseTools: Move Build Cache related function out of CreateAsBuiltInf
>=20
>  BaseTools/Source/Python/AutoGen/AutoGen.py | 73
> ++++++++++++++++++++++++++++++++++++++---------------------------------
> --
>  BaseTools/Source/Python/build/build.py     | 26
> ++++++++++++++++++++++----
>  2 files changed, 60 insertions(+), 39 deletions(-)
>=20
> --
> 2.20.1.windows.1
>=20
>=20
>=20