* [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two
@ 2019-06-24 1:50 Bob Feng
2019-06-24 14:54 ` [edk2-devel] " Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Bob Feng @ 2019-06-24 1:50 UTC (permalink / raw)
To: devel
https://bugzilla.tianocore.org/show_bug.cgi?id=1932
In current implementation, there are 2 functions in CreateAsBuiltInf,
one is create asbuildinf, the other is update build cache.
They should be separated.
Feng, Bob C (2):
BaseTools: refine CreateAsBuiltInf function
BaseTools: Move Build Cache related function out of CreateAsBuiltInf
BaseTools/Source/Python/AutoGen/AutoGen.py | 73 ++++++++++++++++++++++++++++++++++++++-----------------------------------
BaseTools/Source/Python/build/build.py | 26 ++++++++++++++++++++++----
2 files changed, 60 insertions(+), 39 deletions(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two
2019-06-24 1:50 [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two Bob Feng
@ 2019-06-24 14:54 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2019-06-24 14:54 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Much clearer code to see what's actually happening.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Bob Feng
> Sent: Sunday, June 23, 2019 6:51 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch 0/2] BaseTools: Separate current
> CreateAsBuiltInf function into two
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1932
>
> In current implementation, there are 2 functions in CreateAsBuiltInf,
> one is create asbuildinf, the other is update build cache.
> They should be separated.
>
> Feng, Bob C (2):
> BaseTools: refine CreateAsBuiltInf function
> BaseTools: Move Build Cache related function out of CreateAsBuiltInf
>
> BaseTools/Source/Python/AutoGen/AutoGen.py | 73
> ++++++++++++++++++++++++++++++++++++++---------------------------------
> --
> BaseTools/Source/Python/build/build.py | 26
> ++++++++++++++++++++++----
> 2 files changed, 60 insertions(+), 39 deletions(-)
>
> --
> 2.20.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-24 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-24 1:50 [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two Bob Feng
2019-06-24 14:54 ` [edk2-devel] " Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox