From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jaben.carsey@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 10 Jul 2019 16:44:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 16:44:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="168465058" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 10 Jul 2019 16:44:10 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 16:44:09 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.17]) by FMSMSX161.amr.corp.intel.com ([169.254.12.106]) with mapi id 14.03.0439.000; Wed, 10 Jul 2019 16:44:10 -0700 From: "Carsey, Jaben" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Gao, Zhichao" Subject: Re: [Patch] ShellPkg/AcpiView: Fix IA32 link error Thread-Topic: [Patch] ShellPkg/AcpiView: Fix IA32 link error Thread-Index: AQHVN2/B5A2b81/7VEGSYI7o+3hpVqbEg9dA Date: Wed, 10 Jul 2019 23:44:09 +0000 Message-ID: References: <20190710223507.14396-1-michael.d.kinney@intel.com> In-Reply-To: <20190710223507.14396-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTkwZmVlMmMtZTRjZC00MDcxLWJiZGEtN2UwMDJhNjM0MWZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZWpiYVNSVDhzRFRZaEdUdWZYQ3lzcmNiRDVJbTdPWURLUEdXVnE3VDB4M1VIK2dwempyQnkzYlBKWGdtMjNVcCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Return-Path: jaben.carsey@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, July 10, 2019 3:35 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [Patch] ShellPkg/AcpiView: Fix IA32 link error > Importance: High >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1970 >=20 > Update local variable in ParseAcpiSlot() to be UINT32 > instead of UINT64 to avoid 64-bit multiply operation > in the SLIT_ELEMENT() macro. >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Michael D Kinney > --- > .../UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > index 1f9dac66ee..af85c9aa1c 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > @@ -57,8 +57,8 @@ ParseAcpiSlit ( > ) > { > UINT32 Offset; > - UINT64 Count; > - UINT64 Index; > + UINT32 Count; > + UINT32 Index; > UINT64 LocalityCount; > UINT8* LocalityPtr; > CHAR16 Buffer[80]; // Used for AsciiName param of ParseAcpi > -- > 2.21.0.windows.1