From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jaben.carsey@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 18 Jul 2019 07:42:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 07:42:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="319663551" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 18 Jul 2019 07:42:40 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.17]) by FMSMSX106.amr.corp.intel.com ([169.254.5.248]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 07:42:40 -0700 From: "Carsey, Jaben" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "Ni, Ray" , "Gao, Zhichao" , "Sami.Mujawar@arm.com" , "Matteo.Carlini@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 0/8] Remove redundant forward declarations in acpiview Thread-Topic: [PATCH v1 0/8] Remove redundant forward declarations in acpiview Thread-Index: AQHVPVBjZXSidmVTLk6KI3SXwzSl+KbQc2+A Date: Thu, 18 Jul 2019 14:42:40 +0000 Message-ID: References: <20190718100502.24688-1-krzysztof.koch@arm.com> In-Reply-To: <20190718100502.24688-1-krzysztof.koch@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWU4NjM5NzMtZGRlNC00ZTA5LWJhYmMtYmZhMGQxNTg5NzZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiczBxeXNmdFVkK2c4Z3gxVzA2NDc5TzlyVDlNOUxIeHBkTjdrZlU1VDRabHA4UHE4TDVNM2tCOXZUandqYjRkciJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey Thanks -Jaben > -----Original Message----- > From: Krzysztof Koch [mailto:krzysztof.koch@arm.com] > Sent: Thursday, July 18, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Sami.Mujawar@arm.com; > Matteo.Carlini@arm.com; nd@arm.com > Subject: [PATCH v1 0/8] Remove redundant forward declarations in acpiview >=20 > This patch series removes forward static function declarations in the > acpiview table parsers. After repositioning blocks of code, these forward > declarations are no longer needed and they increase the code size. >=20 > What is more, some of the existing ACPI table parsers don't have these > duplicate declarations, so this set of patches makes the code structure > consistent across all acpiview parsers. >=20 > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_remove_forward_decl_ > v1 >=20 > Krzysztof Koch (8): > ShellPkg: acpiview: RSDP: Remove redundant forward declarations > ShellPkg: acpiview: FADT: Remove redundant forward declarations > ShellPkg: acpiview: SPCR: Remove redundant forward declaration > ShellPkg: acpiview: SRAT: Remove redundant forward declarations > ShellPkg: acpiview: MADT: Remove redundant forward declarations > ShellPkg: acpiview: IORT: Remove redundant forward declarations > ShellPkg: acpiview: GTDT: Remove redundant forward declarations > ShellPkg: acpiview: DBG2: Remove redundant forward declarations >=20 >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 62 +++------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 113 ++++++------------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 91 ++++++--------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 58 +++------- >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 118 ++++++++------------ >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 116 +++++++------------ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c > | 98 ++++++---------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 64 +++-------- > 8 files changed, 236 insertions(+), 484 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20