From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jaben.carsey@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Thu, 01 Aug 2019 15:46:43 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 15:46:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,335,1559545200"; 
   d="scan'208";a="372181513"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga005.fm.intel.com with ESMTP; 01 Aug 2019 15:46:42 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 1 Aug 2019 15:46:42 -0700
Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.42]) by
 fmsmsx156.amr.corp.intel.com ([169.254.13.183]) with mapi id 14.03.0439.000;
 Thu, 1 Aug 2019 15:46:42 -0700
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Ni, Ray" <ray.ni@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>, Sami
 Mujawar <sami.mujawar@arm.com>
Subject: Re: [Patch v2 0/2] ShellPkg: Fix IA32 build failure in acpiview
Thread-Topic: [Patch v2 0/2] ShellPkg: Fix IA32 build failure in acpiview
Thread-Index: AQHVSKuI1amVeMgFg0iOszmCRYro5abm5J/g
Date: Thu, 1 Aug 2019 22:46:41 +0000
Message-ID: <CB6E33457884FA40993F35157061515CBCD0996F@FMSMSX103.amr.corp.intel.com>
References: <20190801205541.24792-1-michael.d.kinney@intel.com>
In-Reply-To: <20190801205541.24792-1-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjlkNGZlMTEtMmJjZC00M2MxLTk3NTgtM2MyMTlmOGQyNDI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTWpENm5oN1Bza1Q1MUdsdjhTcXlldEZxZ2J1Vkw4M0lKWlh6VUhcL3hPenZ6NGVGNjM5RVlYbERwbkx6ZTlLenMifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.1.200.106]
MIME-Version: 1.0
Return-Path: jaben.carsey@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Thanks
-Jaben


> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, August 01, 2019 1:56 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Sami Mujawar
> <sami.mujawar@arm.com>
> Subject: [Patch v2 0/2] ShellPkg: Fix IA32 build failure in acpiview
>=20
> Avoid 64-bit multiply operations to prevent intrinsics being added on IA3=
2
> builds.  Add acpiview to a version of the Shell that is build with ShellP=
kg.dsc
> to catch this type of issue in ShellPkg builds.
>=20
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>=20
> Michael D Kinney (2):
>   ShellPkg/AcpiView: Fix IA32 link error
>   ShellPkg: Add shell with all commands integrated
>=20
>  .../Parsers/Slit/SlitParser.c                 |  9 ++++++--
>  ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
>  2 files changed, 28 insertions(+), 3 deletions(-)
>=20
> --
> 2.21.0.windows.1