From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jaben.carsey@intel.com)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by groups.io with SMTP; Thu, 08 Aug 2019 07:51:58 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 07:51:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; 
   d="scan'208";a="193171070"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga001.fm.intel.com with ESMTP; 08 Aug 2019 07:51:57 -0700
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 8 Aug 2019 07:51:57 -0700
Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.141]) by
 FMSMSX110.amr.corp.intel.com ([169.254.14.63]) with mapi id 14.03.0439.000;
 Thu, 8 Aug 2019 07:51:56 -0700
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, "Zhang, Shenglei" <shenglei.zhang@intel.com>
CC: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
Thread-Topic: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib:
 Add missing header files in INF
Thread-Index: AQHVTbINTEPQWbxPE0qYYMgOp038QqbxaO6A///tTrA=
Date: Thu, 8 Aug 2019 14:51:55 +0000
Message-ID: <CB6E33457884FA40993F35157061515CBCD1B693@FMSMSX103.amr.corp.intel.com>
References: <20190808062456.6116-1-shenglei.zhang@intel.com>
 <20190808062456.6116-3-shenglei.zhang@intel.com>
 <3CE959C139B4C44DBEA1810E3AA6F9000B821073@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B821073@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzgwODRhZmUtYzVmZS00NDA2LWIzYTgtNTUzMWI4YTUwOTgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOXRaWGhrUzVIaUNEcFY1bTNBclwvWjNVUHhEWXRiOENPXC85WnZQQ1NPdjJCTG5TNHhpVklJb0RxdzdHNVJuMkxIIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.1.200.108]
MIME-Version: 1.0
Return-Path: jaben.carsey@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Thanks
-Jaben


> -----Original Message-----
> From: Gao, Zhichao
> Sent: Thursday, August 08, 2019 1:59 AM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH 2/3]
> ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
>=20
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>=20
> Thanks,
> Zhichao
>=20
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Zhang, Shenglei
> > Sent: Thursday, August 8, 2019 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>=
;
> > Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [edk2-devel] [PATCH 2/3]
> ShellPkg/UefiShellAcpiViewCommandLib:
> > Add missing header files in INF
> >
> > MadtParser.h and PpttParser.h are actually used but missing INF file, =
which
> > will generate warning message when building this package.
> >
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2
> ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.inf
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.inf
> > index e06e2082a197..1e2fa52b00a3 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.inf
> > +++
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > +++ andLib.inf
> > @@ -43,6 +43,8 @@ [Sources.common]
> >    Parsers/Srat/SratParser.c
> >    Parsers/Ssdt/SsdtParser.c
> >    Parsers/Xsdt/XsdtParser.c
> > +  Parsers/Madt/MadtParser.h
> > +  Parsers/Pptt/PpttParser.h
> >
> >  [Packages]
> >    MdePkg/MdePkg.dec
> > --
> > 2.18.0.windows.1
> >
> >
> >=20