* [PATCH v2 0/3] Fix warning message issues
@ 2019-08-12 6:22 Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Zhang, Shenglei @ 2019-08-12 6:22 UTC (permalink / raw)
To: devel
Cc: Jian J Wang, Hao A Wu, Jaben Carsey, Ray Ni, Zhichao Gao,
Chasel Chiu, Nate DeSimone, Star Zeng
There are some header files used but not included in INF
files. This causes warings are generated when building the
packages. So now add them into INF files.
https://bugzilla.tianocore.org/show_bug.cgi?id=2036
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Shenglei Zhang (3):
MdeModulePkg: Add missing header files in INF files
ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++-
MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 +
MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 ++++++++-
.../UefiShellAcpiViewCommandLib.inf | 2 ++
5 files changed, 15 insertions(+), 3 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files
2019-08-12 6:22 [PATCH v2 0/3] Fix warning message issues Zhang, Shenglei
@ 2019-08-12 6:22 ` Zhang, Shenglei
2019-08-12 6:56 ` Wu, Hao A
2019-08-12 6:22 ` [PATCH v2 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF Zhang, Shenglei
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Zhang, Shenglei @ 2019-08-12 6:22 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Hao A Wu
The header files are used but missing in INF,which causes
generating warning message when building them.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: Add "Common/CommonHeader.h" in CapsuleX64.inf.
MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++-
MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 +
MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 ++++++++-
3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
index 786c41163304..e5078c79863c 100644
--- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
+++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
@@ -6,7 +6,7 @@
# This external input must be validated carefully to avoid security issue like
# buffer overflow, integer overflow.
#
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
# Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -33,6 +33,7 @@ [Sources]
UefiCapsule.c
Capsule.h
Common/CapsuleCoalesce.c
+ Common/CommonHeader.h
[Packages]
MdePkg/MdePkg.dec
diff --git a/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf b/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
index 95e5f68c9892..35d2535a5b48 100644
--- a/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
+++ b/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
@@ -33,6 +33,7 @@ [Sources]
X64/X64Entry.c
X64/PageFaultHandler.nasm
Common/CapsuleCoalesce.c
+ Common/CommonHeader.h
[Packages]
MdePkg/MdePkg.dec
diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
index af002bd98e99..22cf64d9507a 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
@@ -1,7 +1,7 @@
## @file
# EBC Debugger configuration application.
#
-# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -28,6 +28,13 @@ [Sources]
EbcDebugger/EdbCommon.h
EbcDebugger/EdbSupportString.c
EbcDebugger/EdbSupport.h
+ EbcDebugger/EdbCommand.h
+ EbcDebugger/EdbHook.h
+ EbcDebugger/Edb.h
+ EbcDebugger/EdbDisasmSupport.h
+ EbcDebugger/EdbDisasm.h
+ EbcDebugger/EdbSymbol.h
+ EbcDebuggerHook.h
[Packages]
MdePkg/MdePkg.dec
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
2019-08-12 6:22 [PATCH v2 0/3] Fix warning message issues Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
@ 2019-08-12 6:22 ` Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
2019-08-12 14:48 ` [PATCH v2 0/3] Fix warning message issues Carsey, Jaben
3 siblings, 0 replies; 10+ messages in thread
From: Zhang, Shenglei @ 2019-08-12 6:22 UTC (permalink / raw)
To: devel; +Cc: Jaben Carsey, Ray Ni, Zhichao Gao
MadtParser.h and PpttParser.h are actually used but missing INF file,
which will generate warning message when building this package.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
index e06e2082a197..1e2fa52b00a3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
@@ -43,6 +43,8 @@ [Sources.common]
Parsers/Srat/SratParser.c
Parsers/Ssdt/SsdtParser.c
Parsers/Xsdt/XsdtParser.c
+ Parsers/Madt/MadtParser.h
+ Parsers/Pptt/PpttParser.h
[Packages]
MdePkg/MdePkg.dec
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
2019-08-12 6:22 [PATCH v2 0/3] Fix warning message issues Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF Zhang, Shenglei
@ 2019-08-12 6:22 ` Zhang, Shenglei
2019-08-12 6:26 ` Chiu, Chasel
2019-08-13 1:50 ` [edk2-devel] " Nate DeSimone
2019-08-12 14:48 ` [PATCH v2 0/3] Fix warning message issues Carsey, Jaben
3 siblings, 2 replies; 10+ messages in thread
From: Zhang, Shenglei @ 2019-08-12 6:22 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Star Zeng
SecFsp.h is used but missing inf file, which will cause generating
warning message.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
index 3de09b5b4921..17924b118c83 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
@@ -1,7 +1,7 @@
## @file
# Sec Core for FSP
#
-# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -22,6 +22,7 @@ [Defines]
[Sources]
SecFspApiChk.c
+ SecFsp.h
[Sources.IA32]
Ia32/Stack.nasm
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
2019-08-12 6:22 ` [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
@ 2019-08-12 6:26 ` Chiu, Chasel
2019-08-13 1:50 ` [edk2-devel] " Nate DeSimone
1 sibling, 0 replies; 10+ messages in thread
From: Chiu, Chasel @ 2019-08-12 6:26 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, August 12, 2019 2:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in
> INF file
>
> SecFsp.h is used but missing inf file, which will cause generating warning
> message.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> Reviewed-by: Star Zeng <star.zeng@intel.com>
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 3de09b5b4921..17924b118c83 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -1,7 +1,7 @@
> ## @file
> # Sec Core for FSP
> #
> -# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2019, Intel Corporation. All rights
> +reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -22,6 +22,7 @@
> [Defines]
>
> [Sources]
> SecFspApiChk.c
> + SecFsp.h
>
> [Sources.IA32]
> Ia32/Stack.nasm
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files
2019-08-12 6:22 ` [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
@ 2019-08-12 6:56 ` Wu, Hao A
0 siblings, 0 replies; 10+ messages in thread
From: Wu, Hao A @ 2019-08-12 6:56 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Wang, Jian J
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, August 12, 2019 2:23 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files
>
> The header files are used but missing in INF,which causes
> generating warning message when building them.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: Add "Common/CommonHeader.h" in CapsuleX64.inf.
> MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++-
> MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 +
> MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 ++++++++-
> 3 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> index 786c41163304..e5078c79863c 100644
> --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> @@ -6,7 +6,7 @@
> # This external input must be validated carefully to avoid security issue like
> # buffer overflow, integer overflow.
> #
> -# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -33,6 +33,7 @@ [Sources]
> UefiCapsule.c
> Capsule.h
> Common/CapsuleCoalesce.c
> + Common/CommonHeader.h
>
> [Packages]
> MdePkg/MdePkg.dec
> diff --git a/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> b/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> index 95e5f68c9892..35d2535a5b48 100644
> --- a/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> +++ b/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> @@ -33,6 +33,7 @@ [Sources]
> X64/X64Entry.c
> X64/PageFaultHandler.nasm
> Common/CapsuleCoalesce.c
> + Common/CommonHeader.h
>
> [Packages]
> MdePkg/MdePkg.dec
> diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> index af002bd98e99..22cf64d9507a 100644
> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> @@ -1,7 +1,7 @@
> ## @file
> # EBC Debugger configuration application.
> #
> -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -28,6 +28,13 @@ [Sources]
> EbcDebugger/EdbCommon.h
> EbcDebugger/EdbSupportString.c
> EbcDebugger/EdbSupport.h
> + EbcDebugger/EdbCommand.h
> + EbcDebugger/EdbHook.h
> + EbcDebugger/Edb.h
> + EbcDebugger/EdbDisasmSupport.h
> + EbcDebugger/EdbDisasm.h
> + EbcDebugger/EdbSymbol.h
> + EbcDebuggerHook.h
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> [Packages]
> MdePkg/MdePkg.dec
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Fix warning message issues
2019-08-12 6:22 [PATCH v2 0/3] Fix warning message issues Zhang, Shenglei
` (2 preceding siblings ...)
2019-08-12 6:22 ` [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
@ 2019-08-12 14:48 ` Carsey, Jaben
2019-08-13 0:53 ` Zhang, Shenglei
3 siblings, 1 reply; 10+ messages in thread
From: Carsey, Jaben @ 2019-08-12 14:48 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Wang, Jian J, Wu, Hao A, Ni, Ray, Gao, Zhichao, Chiu, Chasel,
Desimone, Nathaniel L, Zeng, Star
What changed in v2?
Thanks
-Jaben
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Sunday, August 11, 2019 11:23 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v2 0/3] Fix warning message issues
>
> There are some header files used but not included in INF
> files. This causes warings are generated when building the
> packages. So now add them into INF files.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2036
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Shenglei Zhang (3):
> MdeModulePkg: Add missing header files in INF files
> ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
> IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
>
> IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
> MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++-
> MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 +
> MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 ++++++++-
> .../UefiShellAcpiViewCommandLib.inf | 2 ++
> 5 files changed, 15 insertions(+), 3 deletions(-)
>
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Fix warning message issues
2019-08-12 14:48 ` [PATCH v2 0/3] Fix warning message issues Carsey, Jaben
@ 2019-08-13 0:53 ` Zhang, Shenglei
2019-08-13 1:28 ` Carsey, Jaben
0 siblings, 1 reply; 10+ messages in thread
From: Zhang, Shenglei @ 2019-08-13 0:53 UTC (permalink / raw)
To: Carsey, Jaben, devel@edk2.groups.io
Cc: Wang, Jian J, Wu, Hao A, Ni, Ray, Gao, Zhichao, Chiu, Chasel,
Desimone, Nathaniel L, Zeng, Star
Jaben:
I add the v2 message below "---". And here is the link for v2 patch.
https://edk2.groups.io/g/devel/message/45398?p=,,,20,0,0,0::Created,,MdeModulePkg%3A+Add+missing+header+files+in+INF+files,20,2,0,32838103
Thanks,
Shenglei
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Monday, August 12, 2019 10:49 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Chiu,
> Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH v2 0/3] Fix warning message issues
>
> What changed in v2?
>
> Thanks
> -Jaben
>
>
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Sunday, August 11, 2019 11:23 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > <hao.a.wu@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Chiu, Chasel
> > <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> > Subject: [PATCH v2 0/3] Fix warning message issues
> >
> > There are some header files used but not included in INF
> > files. This causes warings are generated when building the
> > packages. So now add them into INF files.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2036
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Shenglei Zhang (3):
> > MdeModulePkg: Add missing header files in INF files
> > ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
> > IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
> >
> > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
> > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++-
> > MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 +
> > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9
> ++++++++-
> > .../UefiShellAcpiViewCommandLib.inf | 2 ++
> > 5 files changed, 15 insertions(+), 3 deletions(-)
> >
> > --
> > 2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Fix warning message issues
2019-08-13 0:53 ` Zhang, Shenglei
@ 2019-08-13 1:28 ` Carsey, Jaben
0 siblings, 0 replies; 10+ messages in thread
From: Carsey, Jaben @ 2019-08-13 1:28 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Wang, Jian J, Wu, Hao A, Ni, Ray, Gao, Zhichao, Chiu, Chasel,
Desimone, Nathaniel L, Zeng, Star
Thanks. I had not checked each of the patches in the set, only the one CC'd to me and this one.
Thanks
-Jaben
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, August 12, 2019 5:53 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: RE: [PATCH v2 0/3] Fix warning message issues
>
> Jaben:
>
> I add the v2 message below "---". And here is the link for v2 patch.
> https://edk2.groups.io/g/devel/message/45398?p=,,,20,0,0,0::Created,,Mde
> ModulePkg%3A+Add+missing+header+files+in+INF+files,20,2,0,32838103
>
> Thanks,
> Shenglei
>
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Monday, August 12, 2019 10:49 PM
> > To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>;
> > Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Chiu,
> > Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> > Subject: RE: [PATCH v2 0/3] Fix warning message issues
> >
> > What changed in v2?
> >
> > Thanks
> > -Jaben
> >
> >
> > > -----Original Message-----
> > > From: Zhang, Shenglei
> > > Sent: Sunday, August 11, 2019 11:23 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > > <hao.a.wu@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ni,
> Ray
> > > <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Chiu, Chasel
> > > <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> > > Subject: [PATCH v2 0/3] Fix warning message issues
> > >
> > > There are some header files used but not included in INF
> > > files. This causes warings are generated when building the
> > > packages. So now add them into INF files.
> > > https://bugzilla.tianocore.org/show_bug.cgi?id=2036
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > Cc: Star Zeng <star.zeng@intel.com>
> > > Shenglei Zhang (3):
> > > MdeModulePkg: Add missing header files in INF files
> > > ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
> > > IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
> > >
> > > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
> > > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++-
> > > MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 +
> > > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9
> > ++++++++-
> > > .../UefiShellAcpiViewCommandLib.inf | 2 ++
> > > 5 files changed, 15 insertions(+), 3 deletions(-)
> > >
> > > --
> > > 2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
2019-08-12 6:22 ` [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
2019-08-12 6:26 ` Chiu, Chasel
@ 2019-08-13 1:50 ` Nate DeSimone
1 sibling, 0 replies; 10+ messages in thread
From: Nate DeSimone @ 2019-08-13 1:50 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Chiu, Chasel, Zeng, Star
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, Shenglei
Sent: Sunday, August 11, 2019 11:23 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2-devel] [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
SecFsp.h is used but missing inf file, which will cause generating warning message.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
index 3de09b5b4921..17924b118c83 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
@@ -1,7 +1,7 @@
## @file
# Sec Core for FSP
#
-# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2019, Intel Corporation. All rights
+reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -22,6 +22,7 @@ [Defines]
[Sources]
SecFspApiChk.c
+ SecFsp.h
[Sources.IA32]
Ia32/Stack.nasm
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-08-13 1:50 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-12 6:22 [PATCH v2 0/3] Fix warning message issues Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
2019-08-12 6:56 ` Wu, Hao A
2019-08-12 6:22 ` [PATCH v2 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF Zhang, Shenglei
2019-08-12 6:22 ` [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
2019-08-12 6:26 ` Chiu, Chasel
2019-08-13 1:50 ` [edk2-devel] " Nate DeSimone
2019-08-12 14:48 ` [PATCH v2 0/3] Fix warning message issues Carsey, Jaben
2019-08-13 0:53 ` Zhang, Shenglei
2019-08-13 1:28 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox