From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jaben.carsey@intel.com)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by groups.io with SMTP; Wed, 14 Aug 2019 08:03:39 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
  by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 08:03:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,385,1559545200"; 
   d="scan'208";a="376071930"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga005.fm.intel.com with ESMTP; 14 Aug 2019 08:03:38 -0700
Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 14 Aug 2019 08:03:38 -0700
Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.141]) by
 fmsmsx118.amr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0439.000;
 Wed, 14 Aug 2019 08:03:38 -0700
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "Zhang, Shenglei"
	<shenglei.zhang@intel.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
CC: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
Thread-Topic: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the
 variable "Index"
Thread-Index: AQHVUk1jRBqQEIKy10uUeMyh6s6klqb6c7uAgABKjaA=
Date: Wed, 14 Aug 2019 15:03:38 +0000
Message-ID: <CB6E33457884FA40993F35157061515CBCD2E08A@FMSMSX103.amr.corp.intel.com>
References: <20190814030716.10892-1-shenglei.zhang@intel.com>
 <3CE959C139B4C44DBEA1810E3AA6F9000B8227D7@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8227D7@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWVlODY0YzEtYzFjMi00YmQwLThmMTEtOTJjYWZiMTE5ZmUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieFZZUDB5WGlJVnVvYXhiQ1cyYlIyeWxycWJcL3lweTVaTmdaM1wvazdvVURvd24rYis2RzNIbGo1ellhaEJZVHZQIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.1.200.106]
MIME-Version: 1.0
Return-Path: jaben.carsey@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Thanks
-Jaben


> -----Original Message-----
> From: Gao, Zhichao
> Sent: Tuesday, August 13, 2019 8:37 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove
> the variable "Index"
>=20
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>=20
> Thanks,
> Zhichao
>=20
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Wednesday, August 14, 2019 11:07 AM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove
> the
> > variable "Index"
> >
> > In IortParser.c ,the variable Index is set but not used in function
> > DumpIortNodeNamedComponent. This will cause build failure when
> building
> > ShellPkg with GCC.
> >
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c       | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > index 8912d415a755..f1cdb9ac01d8 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> > +++ er.c
> > @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
> >    )
> >  {
> >    UINT32 Offset;
> > -  UINT32 Index;
> >
> >    Offset =3D ParseAcpi (
> >               TRUE,
> > @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
> >
> >    // Estimate the Device Name length
> >    PrintFieldName (2, L"Device Object Name");
> > -  Index =3D 0;
> >
> >    while ((*(Ptr + Offset) !=3D 0) &&
> >           (Offset < Length)) {
> > --
> > 2.18.0.windows.1