From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jaben.carsey@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Mon, 23 Sep 2019 07:28:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 07:28:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,540,1559545200"; d="scan'208";a="213345746" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 23 Sep 2019 07:28:40 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 07:28:40 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.82]) by FMSMSX102.amr.corp.intel.com ([169.254.10.92]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 07:28:40 -0700 From: "Carsey, Jaben" To: =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Ni, Ray" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call Thread-Topic: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call Thread-Index: AQHVbZE3QWE38dC/gkuW5wDcWEJTgac5hdIA///VYEA= Date: Mon, 23 Sep 2019 14:28:39 +0000 Message-ID: References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-32-lersek@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmRkMWJiYjctNGVjNS00N2RkLTg1NDgtZTNhNjQ2OTZmZmQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZFRtXC9QWFhrOWpkanlzcjZcL28yN3ZBYmdTTE1VSU8xdEZVdit2UEZnSVZtTVVreFF5bUtzTlNpYkx2OUlGSnBFIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Return-Path: jaben.carsey@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UmV2aWV3ZWQtYnk6IEphYmVuIENhcnNleSA8amFiZW4uY2Fyc2V5QGludGVsLmNvbT4NCg0KVGhh bmtzDQotSmFiZW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBQaGls aXBwZSBNYXRoaWV1LURhdWTDqSBbbWFpbHRvOnBoaWxtZEByZWRoYXQuY29tXQ0KPiBTZW50OiBN b25kYXksIFNlcHRlbWJlciAyMywgMjAxOSAzOjAxIEFNDQo+IFRvOiBkZXZlbEBlZGsyLmdyb3Vw cy5pbzsgbGVyc2VrQHJlZGhhdC5jb20NCj4gQ2M6IENhcnNleSwgSmFiZW4gPGphYmVuLmNhcnNl eUBpbnRlbC5jb20+OyBOaSwgUmF5IDxyYXkubmlAaW50ZWwuY29tPjsNCj4gR2FvLCBaaGljaGFv IDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbZWRrMi1kZXZlbF0gW1BB VENIIDMxLzM1XQ0KPiBTaGVsbFBrZy9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYjogZml4IFNo ZWxsQ2xvc2VGaWxlKCkgY2FsbA0KPiANCj4gT24gOS8xNy8xOSA5OjQ5IFBNLCBMYXN6bG8gRXJz ZWsgd3JvdGU6DQo+ID4gSW4gdGhlIEZpbGVCdWZmZXJTYXZlKCkgZnVuY3Rpb24sIHdlIGludm9r ZSBTaGVsbENsb3NlRmlsZSgpIGlmICJEaXJlY3RvcnkNCj4gPiBDYW4gTm90IEJlIFNhdmVkIi4N Cj4gPg0KPiA+IFRoZSBTaGVsbENsb3NlRmlsZSgpIGZ1bmN0aW9uIHRha2VzIGEgKFNIRUxMX0ZJ TEVfSEFORExFKikgcGFyYW1ldGVyDQo+ID4gY2FsbGVkICJGaWxlSGFuZGxlIiwgYW5kIGNvcnJl Y3RseSBwYXNzZXMgdGhlIGRlLXJlZmVyZW5jZWQgKCpGaWxlSGFuZGxlKQ0KPiA+IHRvIEVGSV9T SEVMTF9DTE9TRV9GSUxFLCB3aGljaCB0YWtlcyBhIFNIRUxMX0ZJTEVfSEFORExFLg0KPiA+DQo+ ID4gSG93ZXZlciwgRmlsZUJ1ZmZlclNhdmUoKSBwYXNzZXMgU0hFTExfRklMRV9IQU5ETEUgdG8g U2hlbGxDbG9zZUZpbGUoKSwNCj4gPiBub3QgdGhlIGV4cGVjdGVkIChTSEVMTF9GSUxFX0hBTkRM RSopLiBDb3JyZWN0IGl0Lg0KPiA+DQo+ID4gVGhpcyBmaXhlcyBhbiBhY3R1YWwgYnVnIHRoYXQg aGFzIHJlbWFpbmVkIGhpZGRlbiBmb3IgdHdvIHJlYXNvbnM6DQo+ID4NCj4gPiAtIHBvaW50ZXIt dG8tVk9JRCBjb252ZXJ0cyBmcm9tL3RvIGFueSBwb2ludGVyLXRvLW9iamVjdCB0eXBlIHNpbGVu dGx5LA0KPiA+IC0gdGhlIGJ1ZyBpcyBvbiBhbiBlcnJvciBwYXRoIHdoaWNoIGhhcyBsaWtlbHkg bmV2ZXIgZmlyZWQgaW4gcHJhY3RpY2UuDQo+ID4NCj4gPiBDYzogSmFiZW4gQ2Fyc2V5IDxqYWJl bi5jYXJzZXlAaW50ZWwuY29tPg0KPiA+IENjOiBSYXkgTmkgPHJheS5uaUBpbnRlbC5jb20+DQo+ ID4gQ2M6IFpoaWNoYW8gR2FvIDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+ID4gU2lnbmVkLW9m Zi1ieTogTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4NCj4gPiAtLS0NCj4gPg0KPiA+ IE5vdGVzOg0KPiA+ICAgICB0ZXN0ZWQ6IGVkaXQgKHNhdmluZyBhIGZpbGUpDQo+ID4NCj4gPiAg U2hlbGxQa2cvTGlicmFyeS9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYi9FZGl0L0ZpbGVCdWZm ZXIuYyB8IDIgKy0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0DQo+IGEvU2hlbGxQa2cvTGlicmFyeS9VZWZpU2hl bGxEZWJ1ZzFDb21tYW5kc0xpYi9FZGl0L0ZpbGVCdWZmZXIuYw0KPiBiL1NoZWxsUGtnL0xpYnJh cnkvVWVmaVNoZWxsRGVidWcxQ29tbWFuZHNMaWIvRWRpdC9GaWxlQnVmZmVyLmMNCj4gPiBpbmRl eCA0NjRmOWRlMzhlNTIuLmZkMzI0Y2M0YTg2MSAxMDA2NDQNCj4gPiAtLS0gYS9TaGVsbFBrZy9M aWJyYXJ5L1VlZmlTaGVsbERlYnVnMUNvbW1hbmRzTGliL0VkaXQvRmlsZUJ1ZmZlci5jDQo+ID4g KysrIGIvU2hlbGxQa2cvTGlicmFyeS9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYi9FZGl0L0Zp bGVCdWZmZXIuYw0KPiA+IEBAIC0xNDYyLDcgKzE0NjIsNyBAQCBGaWxlQnVmZmVyU2F2ZSAoDQo+ ID4NCj4gPiAgICAgIGlmIChJbmZvICE9IE5VTEwgJiYgSW5mby0+QXR0cmlidXRlICYgRUZJX0ZJ TEVfRElSRUNUT1JZKSB7DQo+ID4gICAgICAgIFN0YXR1c0JhclNldFN0YXR1c1N0cmluZyAoTCJE aXJlY3RvcnkgQ2FuIE5vdCBCZSBTYXZlZCIpOw0KPiA+IC0gICAgICBTaGVsbENsb3NlRmlsZShG aWxlSGFuZGxlKTsNCj4gPiArICAgICAgU2hlbGxDbG9zZUZpbGUgKCZGaWxlSGFuZGxlKTsNCj4g PiAgICAgICAgRnJlZVBvb2woSW5mbyk7DQo+ID4gICAgICAgIHJldHVybiBFRklfTE9BRF9FUlJP UjsNCj4gPiAgICAgIH0NCj4gPg0KPiANCj4gUmV2aWV3ZWQtYnk6IFBoaWxpcHBlIE1hdGhpZXUt RGF1ZGUgPHBoaWxtZEByZWRoYXQuY29tPg0K