From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DEB4E81C82 for ; Fri, 13 Jan 2017 18:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1484359424; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0w6DaKGLkZii2IloWLHbD8jqxwvQtDPyhz6TsnyYGig=; b=gTPTNWErDRO7cybKNoB3x+cisVz8O5D3e2/lBvrKeu/UjIfAeU62N2F32PVAU9kl aPL1KCJJYA8sN+Sd5jTHFxIXmPQaQEgy3vBB+5zSnYq/ffYl4HebpSEO3av9zdEN P8XC7VXubWLtpU+LtqtXnZ7I5J/tYKenicmYWv4RieM3JxKKUCu2Yrrh9LhPW5l6 NlyYojR5Gq9MQ/AjmOobmzN9c4siiKlj3V/9hhrgvUVjHYe67xZr0OJqmh5XWteP qyR/gjyiR17X7MpeJ0bJNuyEDDKjO3o2UKEStrgcZTl7PomleKfPQH0gt8fDmpgh yMBacFRILckwkKoI2OYNjQ==; Received: from relay4.apple.com (relay4.apple.com [17.128.113.87]) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id 00.70.05063.00789785; Fri, 13 Jan 2017 18:03:44 -0800 (PST) X-AuditID: 11973e16-99e949a0000013c7-3a-587987006a2b Received: from nwk-mmpp-sz08.apple.com (nwk-mmpp-sz08.apple.com [17.128.115.25]) by relay4.apple.com (Apple SCV relay) with SMTP id E6.F2.20305.00789785; Fri, 13 Jan 2017 18:03:44 -0800 (PST) MIME-version: 1.0 Received: from [17.153.44.109] (unknown [17.153.44.109]) by nwk-mmpp-sz08.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OJQ008JJZ27I670@nwk-mmpp-sz08.apple.com>; Fri, 13 Jan 2017 18:03:44 -0800 (PST) Sender: afish@apple.com From: Andrew Fish In-reply-to: <1484294219-3320-1-git-send-email-bhsharma@redhat.com> Date: Fri, 13 Jan 2017 18:03:43 -0800 Cc: Ni Ruiyu , Yao Jiewen , Bhupesh Sharma Message-id: References: <1484294219-3320-1-git-send-email-bhsharma@redhat.com> To: edk2-devel X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsUi2FAYrsvQXhlhcOSghcXCN6dYLfYcOsps se6jh8XLntXsDiwei/e8ZPLonv2PxeP9vqtsAcxRXDYpqTmZZalF+nYJXBkNp28zFywxrVj9 opG1gfGsdhcjJ4eEgIlEx9Eb7F2MXBxCAnsZJZ5O/skMk/jSsYEJxBYSOMgo0XFFF8TmFRCU +DH5HksXIwcHs4C8xMHzsiBhZgEtie+PWlkg5nQxSfx4uIIVJCEsIC7x7swmZgjbX+LpjWss IDabgLLEivkf2EFsTgFniW/zZoDVsAioSqyY3cUOMTRH4sWbNmaIvTYSK+YuhrrHSWLl1z9g c0QENCS2drcyg9wjISArMfuXF8gNEgJH2CTuXVvJPIFReBaSs2chnD0LydkLGJlXMQrlJmbm 6GbmmeslFhTkpOol5+duYgSF/HQ7sR2MD1dZHWIU4GBU4uH9IV4ZIcSaWFZcmXuIUZqDRUmc t8IFKCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoHRfOsMTouEAK/d4SvOWIhFGi/Y5SVyrE2G nX3vYwOHthTneRqi31PXPVLhbEg9uJ7VrzLp7NJ4L8OzLAplbcV+Pydf9EhU/Zo8YxPT7+R1 YT9s0iP/1DAdZVqa/+CZ1c3HE22nnjao2S2sbNAq47xwh/vNpotvH3eruNmpmjn6ipYZ5E5U NFJiKc5INNRiLipOBAA8hhQNWgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42IRbCiW1GVor4wwuDzXyGLhm1OsFnsOHWW2 WPfRw+Jlz2p2BxaPxXteMnl0z/7H4vF+31W2AOYoLpuU1JzMstQifbsEroyG07eZC5aYVqx+ 0cjawHhWu4uRk0NCwETiS8cGJghbTOLCvfVsILaQwEFGiY4ruiA2r4CgxI/J91i6GDk4mAXk JQ6elwUJMwtoSXx/1AoU5gIq72KS+PFwBStIQlhAXOLdmU3MELa/xNMb11hAbDYBZYkV8z+w g9icAs4S3+bNAKthEVCVWDG7ix1iaI7EizdtzBB7bSRWzF3MBHGPk8TKr3/A5ogIaEhs7W5l BrlHQkBWYvYvrwmMgrOQXDoL4dJZSC5dwMi8ilGgKDUnsdJEL7GgICdVLzk/dxMjOHQLw3cw /ltmdYhRgINRiYc3QKoyQog1say4MvcQowQHs5II79sGoBBvSmJlVWpRfnxRaU5q8SHGZKDz JzJLiSbnA+MqryTe0MTEwMTY2MzY2NzEnDRhJXFef8mcCCGB9MSS1OzU1ILUIpgtTBycUg2M VbOnHLngfdVYxMi/7vKeYM2K9q/6QWWxVg7LNtay2Lzm+hXGfZJL9v4RdtcDkwPy52nzvMuV Cmnm9XyV93PSp4COqXwf26tt3h35Fx+4c7arftQlt8/Ou6zepix8IOV7co+bpe32yQ5Wx+/s Or/raPPcj9eiKuSCS5icxRmC61NVDldf1F+jxFKckWioxVxUnAgALm4PcqECAAA= Subject: Re: [PATCH 1/1] AcpiTool: Fix minor casing and file path issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 02:03:45 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Jan 12, 2017, at 11:56 PM, Bhupesh Sharma wrote: > > This patch fixes some minor casing and file path issues Should we add a Linux builder with a case sensitive file system? macOS defaults to case insensitive but our build machines always use a case sensitive filesystem so I've seen my share of case bugs.... One of the tricks we use on macOS is to create a DMG (disk image file) that is case sensitive and then you mount it as /Volumes/Case and you don't have to repartition your disk. I'm guessing you can do something similar in Linux. Thanks, Andrew Fish > with the AcpiToolPkg from Yao Jiewen > (https://github.com/jyao1/EdkiiShellTool). > > This patch also adds AARCH64 as one of the supported architectures > on which AcpiTool can run. > > Compiled and tested this patch under the following environment: > > - Compiled for AARCH64 architecture using GCC4.9 toolchain from Linaro. > - Exercised the 'DumpACPI.efi' thus generated on Qemu for AARCH64 as an > application. > - Able to dump all relevant ACPI tables. > > This patch is also available here for easy access: > https://github.com/bhupesh-sharma/EdkiiShellTool > > Cc: Ni Ruiyu > Cc: Evan Lloyd > Cc: Sami Mujawar > Cc: Yao Jiewen > Signed-off-by: Bhupesh Sharma > Contributed-under: TianoCore Contribution Agreement 1.0 > --- > AcpiToolPkg/AcpiToolPkg.dsc | 2 +- > AcpiToolPkg/DumpAcpi/DumpACPI.c | 2 +- > AcpiToolPkg/DumpAcpi/DumpACPI.h | 2 +- > AcpiToolPkg/DumpAcpi/DumpAcpiDSDT.c | 2 +- > AcpiToolPkg/DumpAcpi/DumpAcpiPSDT.c | 2 +- > AcpiToolPkg/DumpAcpi/DumpAcpiSSDT.c | 2 +- > AcpiToolPkg/Library/DumpAcpi/DumpAcpiDMARLib/DumpAcpiDMARLib.c | 2 +- > .../Library/DumpAcpi/DumpAcpiTableFuncLib/DumpAcpiTableFuncLib.c | 6 +++--- > 8 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/AcpiToolPkg/AcpiToolPkg.dsc b/AcpiToolPkg/AcpiToolPkg.dsc > index 9943f7610315..c0fcec5b2518 100644 > --- a/AcpiToolPkg/AcpiToolPkg.dsc > +++ b/AcpiToolPkg/AcpiToolPkg.dsc > @@ -17,7 +17,7 @@ > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/AcpiToolPkg > - SUPPORTED_ARCHITECTURES = IA32|X64 > + SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > diff --git a/AcpiToolPkg/DumpAcpi/DumpACPI.c b/AcpiToolPkg/DumpAcpi/DumpACPI.c > index 38cc804a72e9..5ea51e67a260 100644 > --- a/AcpiToolPkg/DumpAcpi/DumpACPI.c > +++ b/AcpiToolPkg/DumpAcpi/DumpACPI.c > @@ -23,7 +23,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > #include > > -#include "DumpAcpi.h" > +#include "DumpACPI.h" > > #define RSDP_SIGN_DEFINITION SIGNATURE_32 ('R', 'S', 'D', 'P') > > diff --git a/AcpiToolPkg/DumpAcpi/DumpACPI.h b/AcpiToolPkg/DumpAcpi/DumpACPI.h > index 40c11e70f443..8307f50ec805 100644 > --- a/AcpiToolPkg/DumpAcpi/DumpACPI.h > +++ b/AcpiToolPkg/DumpAcpi/DumpACPI.h > @@ -16,7 +16,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > #include > #include > -#include > +#include > > #ifndef MAX_FILE_NAME_LEN > #define MAX_FILE_NAME_LEN 0x1000 > diff --git a/AcpiToolPkg/DumpAcpi/DumpAcpiDSDT.c b/AcpiToolPkg/DumpAcpi/DumpAcpiDSDT.c > index 42541be92081..764f4b6470ba 100644 > --- a/AcpiToolPkg/DumpAcpi/DumpAcpiDSDT.c > +++ b/AcpiToolPkg/DumpAcpi/DumpAcpiDSDT.c > @@ -24,7 +24,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > > -#include "DumpAcpi.h" > +#include "DumpACPI.h" > > VOID > EFIAPI > diff --git a/AcpiToolPkg/DumpAcpi/DumpAcpiPSDT.c b/AcpiToolPkg/DumpAcpi/DumpAcpiPSDT.c > index 8878d3f6b594..b28e90f18172 100644 > --- a/AcpiToolPkg/DumpAcpi/DumpAcpiPSDT.c > +++ b/AcpiToolPkg/DumpAcpi/DumpAcpiPSDT.c > @@ -24,7 +24,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > > -#include "DumpAcpi.h" > +#include "DumpACPI.h" > > VOID > EFIAPI > diff --git a/AcpiToolPkg/DumpAcpi/DumpAcpiSSDT.c b/AcpiToolPkg/DumpAcpi/DumpAcpiSSDT.c > index 0a268eb136ab..c49b84c18ee0 100644 > --- a/AcpiToolPkg/DumpAcpi/DumpAcpiSSDT.c > +++ b/AcpiToolPkg/DumpAcpi/DumpAcpiSSDT.c > @@ -24,7 +24,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > > -#include "DumpAcpi.h" > +#include "DumpACPI.h" > > VOID > EFIAPI > diff --git a/AcpiToolPkg/Library/DumpAcpi/DumpAcpiDMARLib/DumpAcpiDMARLib.c b/AcpiToolPkg/Library/DumpAcpi/DumpAcpiDMARLib/DumpAcpiDMARLib.c > index 865a213fa706..7d6d8e0b0194 100644 > --- a/AcpiToolPkg/Library/DumpAcpi/DumpAcpiDMARLib/DumpAcpiDMARLib.c > +++ b/AcpiToolPkg/Library/DumpAcpi/DumpAcpiDMARLib/DumpAcpiDMARLib.c > @@ -18,7 +18,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > #include > -#include > +#include > > VOID > DumpDmarDeviceScopeEntry ( > diff --git a/AcpiToolPkg/Library/DumpAcpi/DumpAcpiTableFuncLib/DumpAcpiTableFuncLib.c b/AcpiToolPkg/Library/DumpAcpi/DumpAcpiTableFuncLib/DumpAcpiTableFuncLib.c > index a52a718bfa40..9036926065cb 100644 > --- a/AcpiToolPkg/Library/DumpAcpi/DumpAcpiTableFuncLib/DumpAcpiTableFuncLib.c > +++ b/AcpiToolPkg/Library/DumpAcpi/DumpAcpiTableFuncLib/DumpAcpiTableFuncLib.c > @@ -12,9 +12,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > **/ > > #include > -#include > -#include > -#include > +#include > +#include > +#include > > typedef struct { > UINT32 Signature; > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel