From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Sean Brogan" <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Rebecca Cran <rebecca@bsdio.com>,
Peter Grehan <grehan@freebsd.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-platforms][PATCH v2 0/4] UncrustifyCheck Ignore Support
Date: Fri, 1 Apr 2022 16:48:50 +0000 [thread overview]
Message-ID: <CE8CBB5F-52F3-400B-9B30-A12A9F3EBC85@intel.com> (raw)
In-Reply-To: <20220401162127.2317-1-mikuback@linux.microsoft.com>
for all reviewed-by jiewen.yao@intel.com
thank you!
Yao, Jiewen
> 在 2022年4月2日,上午12:23,mikuback@linux.microsoft.com 写道:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>
> This patch series:
> 1. Updates ignore handling in UncrustifyCheck including adding
> a new CI plugin configuration option to ignore files in a package.
> 2. Reverts Uncrustify changes as requested for files in OvmfPkg.
> 3. Uses the new ignore file option to ignore the files that had
> Uncrustify formatting reverted in OvmfPkg.
>
> V2 Changes:
> 1. [1/4] Normalize file paths returned from
> UncrustifyCheck._get_git_ignored_paths()
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (4):
> .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths
> .pytool/Plugin/UncrustifyCheck: Add ignore file support
> OvmfPkg: Revert Uncrustify formatting in VbeShim.h files
> OvmfPkg: Do not check VbeShim.h formatting with Uncrustify
>
> .pytool/Plugin/UncrustifyCheck/Readme.md | 7 +
> .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 31 +-
> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h | 1811 ++++++++++----------
> OvmfPkg/OvmfPkg.ci.yaml | 5 +
> OvmfPkg/QemuVideoDxe/VbeShim.h | 1389 ++++++++-------
> 5 files changed, 1641 insertions(+), 1602 deletions(-)
>
> --
> 2.28.0.windows.1
>
prev parent reply other threads:[~2022-04-01 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 16:21 [edk2-platforms][PATCH v2 0/4] UncrustifyCheck Ignore Support Michael Kubacki
2022-04-01 16:21 ` [edk2-platforms][PATCH v2 1/4] .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths Michael Kubacki
2022-04-01 16:21 ` [edk2-platforms][PATCH v2 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support Michael Kubacki
2022-04-01 16:40 ` [edk2-devel] " Sean
2022-04-01 16:21 ` [edk2-platforms][PATCH v2 3/4] OvmfPkg: Revert Uncrustify formatting in VbeShim.h files Michael Kubacki
2022-04-01 16:21 ` [edk2-platforms][PATCH v2 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify Michael Kubacki
2022-04-01 16:48 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE8CBB5F-52F3-400B-9B30-A12A9F3EBC85@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox