From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ma1-aaemail-dr-lapp02.apple.com (ma1-aaemail-dr-lapp02.apple.com [17.171.2.68]) by mx.groups.io with SMTP id smtpd.web11.36691.1590431327796125736 for ; Mon, 25 May 2020 11:28:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=vftZZT6b; spf=pass (domain: apple.com, ip: 17.171.2.68, mailfrom: afish@apple.com) Received: from pps.filterd (ma1-aaemail-dr-lapp02.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp02.apple.com (8.16.0.42/8.16.0.42) with SMTP id 04PIKJ3G043447; Mon, 25 May 2020 11:28:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=fxe1ymKfuTr33OGOLCf4smUn/sUi851PKtVGA+vttJo=; b=vftZZT6bXLaSRzmMGrPQGAObwY4Nw55hV4YwjtoKpo2B/sMlLVgJ614/rwD72n68UKE/ BxLW6yXwnVW2E1MmqMqTvs3/KxU6ap/GOlIMUcD4cXJr2im/jNZAQXp1pwnEnSenlPYk eJBSs2UwIlta6hfV2A5cCym5tcq1DtE4LbNpZmL5AWXeSN7BNI0Dv+9G8C+vrrxZsyu3 RKplxn+HfhUOKKaKbyH6gkD2yqt9EqIjIwg/6At6+13JpXv8V9VoXDxquzzR3UtDXO+b y+v2ztac26gA8pSLAHD+cVAD+qlwGI9TiKCtcCUWJ0WwxbTU4Osub0kHgP+qlqzdOpO1 ng== Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by ma1-aaemail-dr-lapp02.apple.com with ESMTP id 3170gs3ugd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 25 May 2020 11:28:46 -0700 Received: from rn-mailsvcp-mmp-lapp01.rno.apple.com (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QAW0066RGNXZK90@rn-mailsvcp-mta-lapp03.rno.apple.com>; Mon, 25 May 2020 11:28:45 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QAW00M00G9LPR00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Mon, 25 May 2020 11:28:45 -0700 (PDT) X-Va-A: X-Va-T-CD: a896650d2b2ee8463fb615bccff4df55 X-Va-E-CD: ae7e8bcefd1a81dc01b015b2ad8da7af X-Va-R-CD: d025988ae18465e19d6e8e1ab625b1c2 X-Va-CD: 0 X-Va-ID: 1f64975e-2da4-4e53-b3f1-7bb120958099 X-V-A: X-V-T-CD: a896650d2b2ee8463fb615bccff4df55 X-V-E-CD: ae7e8bcefd1a81dc01b015b2ad8da7af X-V-R-CD: d025988ae18465e19d6e8e1ab625b1c2 X-V-CD: 0 X-V-ID: 05084fe1-3ff3-434d-8384-a5e0d0e1e511 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-05-25_10:2020-05-25,2020-05-25 signatures=0 Received: from [17.235.10.166] (unknown [17.235.10.166]) by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QAW0105XGNWYC00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Mon, 25 May 2020 11:28:45 -0700 (PDT) MIME-version: 1.0 (Mac OS X Mail 13.0 \(3594.4.17\)) Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process From: "Andrew Fish" In-reply-to: Date: Mon, 25 May 2020 11:28:43 -0700 Cc: Bret Barkelew , "devel@edk2.groups.io" , "spbrogan@outlook.com" , "rfc@edk2.groups.io" , "Desimone, Nathaniel L" , Mike Kinney , "Leif Lindholm (Nuvia address)" Message-id: References: <2107AEA7-9145-4FC9-9E1A-C396F23877ED@apple.com> To: Laszlo Ersek X-Mailer: Apple Mail (2.3594.4.17) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-05-25_10:2020-05-25,2020-05-25 signatures=0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable > On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: >=20 > Hi Andrew, >=20 > On 05/25/20 06:09, Andrew Fish wrote: >=20 >> I also found I had to Bing/Google to find the detailed instructions I >> needed as a developer, as the Wiki seems to assume you just know the >> Linux kernel patch process. That feels like an area we can improve. >=20 > (apologies if I've lost context; please disregard my message below in > that case). >=20 > I wrote the following wiki article originally in 2016: >=20 > = https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git= -guide-for-edk2-contributors-and-maintainers >=20 > I wrote it specifically for developers & maintainers with no (or = almost > no) prior git / mailing list experience. Multiple developers confirmed > later that the article had helped them. >=20 Laszlo, Your wiki article was very very helpful. I just could not find it from = the Tianocre wiki. It would be good if we could link to it from here = [1], maybe as add to this: "Are you new to using git? If so, then the = New to git page may be helpful."? There are a lot folks who use git but don't use the email based review = so they have never setup git with emali before. Your wiki, plus me = figuring out the magic internal SMTP reflector (I reached out on an = internal git malling list) is what got me unblocked.=20 [1] = https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-P= rocess Thanks, Andrew Fish > Thanks > Laszlo >=20