public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references
Date: Tue, 21 Nov 2023 02:17:30 +0000	[thread overview]
Message-ID: <CH0PR11MB547538089A02E745C4286198E6BBA@CH0PR11MB5475.namprd11.prod.outlook.com> (raw)
In-Reply-To: <05a49037-1b6f-f47f-0626-34ef61405a47@redhat.com>


Hi Laszlo,

I think you have to clone all the required repos.
edk2 repository
git clone https://github.com/tianocore/edk2.git

edk2-platforms repository
git clone https://github.com/tianocore/edk2-platforms.git

edk2-non-osi repository
git clone https://github.com/tianocore/edk2-non-osi.git

FSP repository
git clone https://github.com/IntelFsp/FSP.git

check if you got all repos like below:
edk2
edk2-non-osi
edk2-platforms
FSP

Then switch to edk2-platforms/Platform/Intel/build_bios.py -p WilsonCityRvp to start the build

Detail information is in readme: https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md

Please let me know if any question.

Thanks,
Chasel





> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, November 15, 2023 3:51 AM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> Hi Chasel,
> 
> On 11/10/23 02:13, Chiu, Chasel wrote:
> >
> > Hi Laszlo,
> >
> > I verified and encountered build failure as some files still consuming definitions
> from LegacyBiosMpTable.h, for example:
> > https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd5469051338
> >
> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
> m
> > mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> >
> > Any suggestion that we can reduce impact to existing platforms?
> 
> I've been hoping to get comments from Nate on the expected contents of
> DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
> I'd like to just replace the enum constants in question with their numerical values.
> 
> However, even for that, I'd really like to be able to build-test the platform locally.
> Do you have build instructions? How can I satisfy the FSP blob requirement?
> 
> Thanks!
> Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111499): https://edk2.groups.io/g/devel/message/111499
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-21  2:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 12:05 [edk2-devel] remove <LegacyBiosMpTable.h> and <Mps.h>, including references Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [edk2-platforms PATCH 0/2] remove <LegacyBiosMpTable.h> and <Mps.h> refs Laszlo Ersek
2023-11-09 12:06   ` [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references Laszlo Ersek
2023-11-10  1:13     ` Chiu, Chasel
2023-11-13 10:37       ` Laszlo Ersek
2023-11-15 11:51       ` Laszlo Ersek
2023-11-21  2:17         ` Chiu, Chasel [this message]
2023-11-23 10:04           ` Laszlo Ersek
2023-11-27 18:37             ` Chiu, Chasel
2023-11-27 23:14           ` Pedro Falcato
2023-11-28  3:47             ` Chiu, Chasel
2023-11-09 12:06   ` [edk2-devel] [edk2-platforms PATCH 2/2] SimicsOpenBoardPkg: remove <Mps.h> reference Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [PATCH 0/3] remove <LegacyBiosMpTable.h> and <Mps.h>, including refs Laszlo Ersek
2023-11-09 12:06   ` [edk2-devel] [PATCH 1/3] MdePkg: remove <LegacyBiosMpTable.h> Laszlo Ersek
2023-11-09 12:06   ` [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM Laszlo Ersek
2023-11-21  8:51     ` Gao, Zhichao
2023-11-09 12:06   ` [edk2-devel] [PATCH 3/3] MdePkg: remove <Mps.h> Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH0PR11MB547538089A02E745C4286198E6BBA@CH0PR11MB5475.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox