Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

["Chiu, Chasel" <chasel.chiu@intel.com>]

Hi Laszlo,

I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22

Any suggestion that we can reduce impact to existing platforms?

Thanks,
Chasel



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, November 9, 2023 4:06 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
> edk2, first remove the edk2-platforms references to that header file.
> 
> I can't build-test this change. As far as I can tell, building the CooperCityRvp and
> WilsonCityRvp platforms with "build_bios.py" should build these changes;
> however, both platforms fail to build without FSP blobs.
> 
> I think there's a fair chance that this patch should work nonetheless;
> <LegacyBiosMpTable.h> introduces names prefixed with
> EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (The
> one exception is FEATUREBYTE2_5, which is also absent from edk2-platforms.)
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar
> dInfoDxe/SystemBoardInfoDxe.h | 1 -
> 
> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform
> DeviceDataSRP10nm.c       | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> index 32c16ff9110a..d8c209a57f75 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> +++ ardInfoDxe/SystemBoardInfoDxe.h
> @@ -27,7 +27,6 @@
>  #include <Platform.h>
>  #include <Ppi/PchPolicy.h>
> 
> -#include <IndustryStandard/LegacyBiosMpTable.h>
>  #include <UncoreCommonIncludes.h>
> 
>  #endif  //_SYSTEM_BOARD_INFO_DXE_H_
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> index ed9f80734cd7..b69ae1736bb8 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl
> +++ atformDeviceDataSRP10nm.c
> @@ -8,7 +8,6 @@
> 
>  #include <PlatPirqData.h>
>  #include <PlatDevData.h>
> -#include <IndustryStandard/LegacyBiosMpTable.h>
> 
>  #ifndef V_INTEL_VID
>  #define V_INTEL_VID               0x8086
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111005): https://edk2.groups.io/g/devel/message/111005
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-